core/fpdfapi/page/cpdf_streamparser.cpp - Issue 2509123002: Make CPDF_Object subclass constructors intern strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/cpdf_streamparser.cpp

Issue 2509123002: Make CPDF_Object subclass constructors intern strings (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/cpdf_streamparser.cpp

diff --git a/core/fpdfapi/page/cpdf_streamparser.cpp b/core/fpdfapi/page/cpdf_streamparser.cpp

index b149f1fb9893ed0f98ad8061d7ca50912f630f8d..338d85fcaf5e0aea155c368e6ebc860d00c773fd 100644

--- a/core/fpdfapi/page/cpdf_streamparser.cpp

+++ b/core/fpdfapi/page/cpdf_streamparser.cpp

@@ -336,7 +336,7 @@ CPDF_Object* CPDF_StreamParser::ReadNextObject(bool bAllowNestedArray,

if (first_char == '/') {

CFX_ByteString name =

PDF_NameDecode(CFX_ByteStringC(m_WordBuffer + 1, m_WordSize - 1));

- return new CPDF_Name(m_pPool ? m_pPool->Intern(name) : name);

+ return new CPDF_Name(m_pPool, name);

}

if (first_char == '(') {