Make CPDF_Object subclass constructors intern strings

fpdfsdk/fpdfppo.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "public/fpdf_ppo.h"
 
 #include <map>
 #include <memory>
@@ skipping 142 matching lines @@
   CPDF_Dictionary* pNewRoot = m_pDestPDFDoc->GetRoot();
   if (!pNewRoot)
     return false;
 
   CPDF_Dictionary* pDocInfoDict = m_pDestPDFDoc->GetInfo();
   if (!pDocInfoDict)
     return false;
 
   CFX_ByteString producerstr;
   producerstr.Format("PDFium");
-  pDocInfoDict->SetFor("Producer", new CPDF_String(producerstr, false));
+  pDocInfoDict->SetFor("Producer",
+                       new CPDF_String(nullptr, producerstr, false));
 
   CFX_ByteString cbRootType = pNewRoot->GetStringFor("Type", "");
   if (cbRootType.IsEmpty())
-    pNewRoot->SetFor("Type", new CPDF_Name("Catalog"));
+    pNewRoot->SetFor("Type", new CPDF_Name(nullptr, "Catalog"));
 
   CPDF_Object* pElement = pNewRoot->GetObjectFor("Pages");
   CPDF_Dictionary* pNewPages =
       pElement ? ToDictionary(pElement->GetDirect()) : nullptr;
   if (!pNewPages) {
-    pNewPages = m_pDestPDFDoc->NewIndirect<CPDF_Dictionary>(
-        m_pDestPDFDoc->GetByteStringPool());
+    pNewPages = m_pDestPDFDoc->NewIndirect<CPDF_Dictionary>();
     pNewRoot->SetReferenceFor("Pages", m_pDestPDFDoc, pNewPages);
   }
 
   CFX_ByteString cbPageType = pNewPages->GetStringFor("Type", "");
   if (cbPageType.IsEmpty())
-    pNewPages->SetFor("Type", new CPDF_Name("Pages"));
+    pNewPages->SetFor("Type", new CPDF_Name(nullptr, "Pages"));
 
   if (!pNewPages->GetArrayFor("Kids")) {
     pNewPages->SetIntegerFor("Count", 0);
     pNewPages->SetReferenceFor("Kids", m_pDestPDFDoc,
                                m_pDestPDFDoc->NewIndirect<CPDF_Array>());
   }
 
   return true;
 }
 
@@ skipping 192 matching lines @@
     return false;
 
   CPDF_Dictionary* pDstDict = pDstDoc->GetRoot();
   if (!pDstDict)
     return false;
 
   pDstDict->SetFor("ViewerPreferences",
                    pSrcDict->CloneDirectObject().release());
   return true;
 }