Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: core/fxcrt/cfx_weak_ptr.h

Issue 2509123002: Make CPDF_Object subclass constructors intern strings (Closed)
Patch Set: Nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfdoc/cpvt_generateap.cpp ('k') | fpdfsdk/formfiller/cba_fontmap.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FXCRT_CFX_WEAK_PTR_H_ 7 #ifndef CORE_FXCRT_CFX_WEAK_PTR_H_
8 #define CORE_FXCRT_CFX_WEAK_PTR_H_ 8 #define CORE_FXCRT_CFX_WEAK_PTR_H_
9 9
10 #include <cstddef>
10 #include <memory> 11 #include <memory>
11 12
12 #include "core/fxcrt/cfx_retain_ptr.h" 13 #include "core/fxcrt/cfx_retain_ptr.h"
13 #include "core/fxcrt/fx_system.h" 14 #include "core/fxcrt/fx_system.h"
14 15
15 template <class T, class D = std::default_delete<T>> 16 template <class T, class D = std::default_delete<T>>
16 class CFX_WeakPtr { 17 class CFX_WeakPtr {
17 public: 18 public:
18 CFX_WeakPtr() {} 19 CFX_WeakPtr() {}
19 CFX_WeakPtr(const CFX_WeakPtr& that) : m_pHandle(that.m_pHandle) {} 20 CFX_WeakPtr(const CFX_WeakPtr& that) : m_pHandle(that.m_pHandle) {}
20 CFX_WeakPtr(CFX_WeakPtr&& that) { Swap(that); } 21 CFX_WeakPtr(CFX_WeakPtr&& that) { Swap(that); }
21 CFX_WeakPtr(std::unique_ptr<T, D> pObj) 22 CFX_WeakPtr(std::unique_ptr<T, D> pObj)
22 : m_pHandle(new Handle(std::move(pObj))) {} 23 : m_pHandle(new Handle(std::move(pObj))) {}
23 24
25 // Deliberately implicit to allow passing nullptr.
26 CFX_WeakPtr(std::nullptr_t arg) {}
27
24 explicit operator bool() const { return m_pHandle && !!m_pHandle->Get(); } 28 explicit operator bool() const { return m_pHandle && !!m_pHandle->Get(); }
25 bool HasOneRef() const { return m_pHandle && m_pHandle->HasOneRef(); } 29 bool HasOneRef() const { return m_pHandle && m_pHandle->HasOneRef(); }
26 T* operator->() { return m_pHandle->Get(); } 30 T* operator->() { return m_pHandle->Get(); }
27 const T* operator->() const { return m_pHandle->Get(); } 31 const T* operator->() const { return m_pHandle->Get(); }
28 CFX_WeakPtr& operator=(const CFX_WeakPtr& that) { 32 CFX_WeakPtr& operator=(const CFX_WeakPtr& that) {
29 m_pHandle = that.m_pHandle; 33 m_pHandle = that.m_pHandle;
30 return *this; 34 return *this;
31 } 35 }
32 bool operator==(const CFX_WeakPtr& that) const { 36 bool operator==(const CFX_WeakPtr& that) const {
33 return m_pHandle == that.m_pHandle; 37 return m_pHandle == that.m_pHandle;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 ~Handle() {} 75 ~Handle() {}
72 76
73 intptr_t m_nCount; 77 intptr_t m_nCount;
74 std::unique_ptr<T, D> m_pObj; 78 std::unique_ptr<T, D> m_pObj;
75 }; 79 };
76 80
77 CFX_RetainPtr<Handle> m_pHandle; 81 CFX_RetainPtr<Handle> m_pHandle;
78 }; 82 };
79 83
80 #endif // CORE_FXCRT_CFX_WEAK_PTR_H_ 84 #endif // CORE_FXCRT_CFX_WEAK_PTR_H_
OLDNEW
« no previous file with comments | « core/fpdfdoc/cpvt_generateap.cpp ('k') | fpdfsdk/formfiller/cba_fontmap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698