Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: core/fpdfapi/parser/cpdf_string.h

Issue 2509123002: Make CPDF_Object subclass constructors intern strings (Closed)
Patch Set: Nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/parser/cpdf_object_unittest.cpp ('k') | core/fpdfapi/parser/cpdf_string.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef CORE_FPDFAPI_PARSER_CPDF_STRING_H_ 7 #ifndef CORE_FPDFAPI_PARSER_CPDF_STRING_H_
8 #define CORE_FPDFAPI_PARSER_CPDF_STRING_H_ 8 #define CORE_FPDFAPI_PARSER_CPDF_STRING_H_
9 9
10 #include "core/fpdfapi/parser/cpdf_object.h" 10 #include "core/fpdfapi/parser/cpdf_object.h"
11 #include "core/fxcrt/cfx_string_pool_template.h"
12 #include "core/fxcrt/cfx_weak_ptr.h"
11 #include "core/fxcrt/fx_string.h" 13 #include "core/fxcrt/fx_string.h"
12 #include "core/fxcrt/fx_system.h" 14 #include "core/fxcrt/fx_system.h"
13 15
14 class CPDF_String : public CPDF_Object { 16 class CPDF_String : public CPDF_Object {
15 public: 17 public:
16 CPDF_String(); 18 CPDF_String();
17 CPDF_String(const CFX_ByteString& str, bool bHex); 19 CPDF_String(CFX_WeakPtr<CFX_ByteStringPool> pPool,
20 const CFX_ByteString& str,
21 bool bHex);
18 explicit CPDF_String(const CFX_WideString& str); 22 explicit CPDF_String(const CFX_WideString& str);
19 ~CPDF_String() override; 23 ~CPDF_String() override;
20 24
21 // CPDF_Object: 25 // CPDF_Object:
22 Type GetType() const override; 26 Type GetType() const override;
23 std::unique_ptr<CPDF_Object> Clone() const override; 27 std::unique_ptr<CPDF_Object> Clone() const override;
24 CFX_ByteString GetString() const override; 28 CFX_ByteString GetString() const override;
25 CFX_WideString GetUnicodeText() const override; 29 CFX_WideString GetUnicodeText() const override;
26 void SetString(const CFX_ByteString& str) override; 30 void SetString(const CFX_ByteString& str) override;
27 bool IsString() const override; 31 bool IsString() const override;
28 CPDF_String* AsString() override; 32 CPDF_String* AsString() override;
29 const CPDF_String* AsString() const override; 33 const CPDF_String* AsString() const override;
30 34
31 bool IsHex() const { return m_bHex; } 35 bool IsHex() const { return m_bHex; }
32 36
33 protected: 37 protected:
34 CFX_ByteString m_String; 38 CFX_ByteString m_String;
35 bool m_bHex; 39 bool m_bHex;
36 }; 40 };
37 41
38 inline CPDF_String* ToString(CPDF_Object* obj) { 42 inline CPDF_String* ToString(CPDF_Object* obj) {
39 return obj ? obj->AsString() : nullptr; 43 return obj ? obj->AsString() : nullptr;
40 } 44 }
41 45
42 inline const CPDF_String* ToString(const CPDF_Object* obj) { 46 inline const CPDF_String* ToString(const CPDF_Object* obj) {
43 return obj ? obj->AsString() : nullptr; 47 return obj ? obj->AsString() : nullptr;
44 } 48 }
45 49
46 #endif // CORE_FPDFAPI_PARSER_CPDF_STRING_H_ 50 #endif // CORE_FPDFAPI_PARSER_CPDF_STRING_H_
OLDNEW
« no previous file with comments | « core/fpdfapi/parser/cpdf_object_unittest.cpp ('k') | core/fpdfapi/parser/cpdf_string.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698