Make CPDF_Object subclass constructors intern strings

core/fpdfapi/parser/cpdf_string.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/parser/cpdf_string.h"
 
 #include "core/fpdfapi/parser/fpdf_parser_decode.h"
 #include "third_party/base/ptr_util.h"
 
 CPDF_String::CPDF_String() : m_bHex(false) {}
 
-CPDF_String::CPDF_String(const CFX_ByteString& str, bool bHex)
-    : m_String(str), m_bHex(bHex) {}
+CPDF_String::CPDF_String(CFX_WeakPtr<CFX_ByteStringPool> pPool,
+                         const CFX_ByteString& str,
+                         bool bHex)
+    : m_String(str), m_bHex(bHex) {
+  if (pPool)
+    m_String = pPool->Intern(m_String);
+}
 
 CPDF_String::CPDF_String(const CFX_WideString& str) : m_bHex(false) {
   m_String = PDF_EncodeText(str);
 }
 
 CPDF_String::~CPDF_String() {}
 
 CPDF_Object::Type CPDF_String::GetType() const {
   return STRING;
 }
 
 std::unique_ptr<CPDF_Object> CPDF_String::Clone() const {
-  return pdfium::MakeUnique<CPDF_String>(m_String, m_bHex);
+  auto pRet = pdfium::MakeUnique<CPDF_String>();
+  pRet->m_String = m_String;
+  pRet->m_bHex = m_bHex;
+  return std::move(pRet);
 }
 
 CFX_ByteString CPDF_String::GetString() const {
   return m_String;
 }
 
 void CPDF_String::SetString(const CFX_ByteString& str) {
   m_String = str;
 }
 
 bool CPDF_String::IsString() const {
   return true;
 }
 
 CPDF_String* CPDF_String::AsString() {
   return this;
 }
 
 const CPDF_String* CPDF_String::AsString() const {
   return this;
 }
 
 CFX_WideString CPDF_String::GetUnicodeText() const {
   return PDF_DecodeText(m_String);
 }