Make CPDF_Object subclass constructors intern strings

core/fpdfapi/parser/cpdf_dictionary.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/parser/cpdf_dictionary.h"
 
 #include <set>
 #include <utility>
@@ skipping 220 matching lines @@
   }
   m_Map.erase(old_it);
 }
 
 void CPDF_Dictionary::SetIntegerFor(const CFX_ByteString& key, int i) {
   SetFor(key, new CPDF_Number(i));
 }
 
 void CPDF_Dictionary::SetNameFor(const CFX_ByteString& key,
                                  const CFX_ByteString& name) {
-  SetFor(key, new CPDF_Name(MaybeIntern(name)));
+  SetFor(key, new CPDF_Name(GetByteStringPool(), name));
 }
 
 void CPDF_Dictionary::SetStringFor(const CFX_ByteString& key,
                                    const CFX_ByteString& str) {
-  SetFor(key, new CPDF_String(MaybeIntern(str), false));
+  SetFor(key, new CPDF_String(GetByteStringPool(), str, false));
 }
 
 void CPDF_Dictionary::SetReferenceFor(const CFX_ByteString& key,
                                       CPDF_IndirectObjectHolder* pDoc,
                                       uint32_t objnum) {
   SetFor(key, new CPDF_Reference(pDoc, objnum));
 }
 
 void CPDF_Dictionary::SetReferenceFor(const CFX_ByteString& key,
                                       CPDF_IndirectObjectHolder* pDoc,
@@ skipping 28 matching lines @@
   pArray->AddNew<CPDF_Number>(matrix.c);
   pArray->AddNew<CPDF_Number>(matrix.d);
   pArray->AddNew<CPDF_Number>(matrix.e);
   pArray->AddNew<CPDF_Number>(matrix.f);
   SetFor(key, pArray);
 }
 
 CFX_ByteString CPDF_Dictionary::MaybeIntern(const CFX_ByteString& str) {
   return m_pPool ? m_pPool->Intern(str) : str;
 }