Make CPDF_Object subclass constructors intern strings

core/fpdfapi/page/cpdf_streamcontentparser.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/page/cpdf_streamcontentparser.h"
 
 #include <memory>
 #include <utility>
@@ skipping 305 matching lines @@
   }
   m_ParamCount++;
   return index;
 }
 
 void CPDF_StreamContentParser::AddNameParam(const FX_CHAR* name, int len) {
   CFX_ByteStringC bsName(name, len);
   ContentParam& param = m_ParamBuf[GetNextParamPos()];
   if (len > 32) {
     param.m_Type = ContentParam::OBJECT;
-    param.m_pObject = new CPDF_Name(
-        m_pDocument->GetByteStringPool()->Intern(PDF_NameDecode(bsName)));
+    param.m_pObject =
+        new CPDF_Name(m_pDocument->GetByteStringPool(), PDF_NameDecode(bsName));
   } else {
     param.m_Type = ContentParam::NAME;
     if (bsName.Find('#') == -1) {
       FXSYS_memcpy(param.m_Name.m_Buffer, name, len);
       param.m_Name.m_Len = len;
     } else {
       CFX_ByteString str = PDF_NameDecode(bsName);
       FXSYS_memcpy(param.m_Name.m_Buffer, str.c_str(), str.GetLength());
       param.m_Name.m_Len = str.GetLength();
     }
@@ skipping 40 matching lines @@
   if (param.m_Type == ContentParam::NUMBER) {
     CPDF_Number* pNumber = param.m_Number.m_bInteger
                                ? new CPDF_Number(param.m_Number.m_Integer)
                                : new CPDF_Number(param.m_Number.m_Float);
 
     param.m_Type = ContentParam::OBJECT;
     param.m_pObject = pNumber;
     return pNumber;
   }
   if (param.m_Type == ContentParam::NAME) {
-    CPDF_Name* pName = new CPDF_Name(m_pDocument->GetByteStringPool()->Intern(
-        CFX_ByteString(param.m_Name.m_Buffer, param.m_Name.m_Len)));
+    CPDF_Name* pName = new CPDF_Name(
+        m_pDocument->GetByteStringPool(),
+        CFX_ByteString(param.m_Name.m_Buffer, param.m_Name.m_Len));
     param.m_Type = ContentParam::OBJECT;
     param.m_pObject = pName;
     return pName;
   }
   if (param.m_Type == ContentParam::OBJECT) {
     return param.m_pObject;
   }
   ASSERT(false);
   return nullptr;
 }
@@ skipping 1261 matching lines @@
       }
       default:
         bProcessed = false;
     }
     if (!bProcessed) {
       m_pSyntax->SetPos(last_pos);
       return;
     }
   }
 }