Make CPDF_Object subclass constructors intern strings

fpdfsdk/fpdfeditpage.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "public/fpdf_edit.h"
 
 #include <algorithm>
 #include <memory>
@@ skipping 65 matching lines @@
         DateStr.Format("D:%04d%02d%02d%02d%02d%02d", pTM->tm_year + 1900,
                        pTM->tm_mon + 1, pTM->tm_mday, pTM->tm_hour, pTM->tm_min,
                        pTM->tm_sec);
       }
     }
   }
 
   CPDF_Dictionary* pInfoDict = nullptr;
   pInfoDict = pDoc->GetInfo();
   if (pInfoDict) {
     if (FSDK_IsSandBoxPolicyEnabled(FPDF_POLICY_MACHINETIME_ACCESS))

[Lei Zhang, 2016/11/17 01:05:06]

braces

[Tom Sepez, 2016/11/17 01:13:48]

Done.

-      pInfoDict->SetFor("CreationDate", new CPDF_String(DateStr, false));
+      pInfoDict->SetFor("CreationDate",
+                        new CPDF_String(nullptr, DateStr, false));
     pInfoDict->SetFor("Creator", new CPDF_String(L"PDFium"));
   }
 
   return FPDFDocumentFromCPDFDocument(pDoc);
 }
 
 DLLEXPORT void STDCALL FPDFPage_Delete(FPDF_DOCUMENT document, int page_index) {
   if (UnderlyingDocumentType* pDoc = UnderlyingFromFPDFDocument(document))
     pDoc->DeletePage(page_index);
 }
@@ skipping 211 matching lines @@
 
 DLLEXPORT void STDCALL FPDFPage_SetRotation(FPDF_PAGE page, int rotate) {
   CPDF_Page* pPage = CPDFPageFromFPDFPage(page);
   if (!IsPageObject(pPage))
     return;
 
   CPDF_Dictionary* pDict = pPage->m_pFormDict;
   rotate %= 4;
   pDict->SetFor("Rotate", new CPDF_Number(rotate * 90));
 }