Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2509113004: Don't paint SVG image documents unless actually painting. (Closed)

Created:
4 years, 1 month ago by chrishtr
Modified:
4 years, 1 month ago
Reviewers:
pdr., Xianzhu
CC:
blink-reviews, chromium-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't paint SVG image documents unless actually painting. BUG=663953 TEST=paint/invalidation/svg/image-animation-with-zoom.html Committed: https://crrev.com/8934714bb524f1a32b6d5434fea0ac59660cf6ff Cr-Commit-Position: refs/heads/master@{#433228}

Patch Set 1 #

Patch Set 2 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
chrishtr
4 years, 1 month ago (2016-11-17 19:16:31 UTC) #3
pdr.
On 2016/11/17 at 19:16:31, chrishtr wrote: > LGTM
4 years, 1 month ago (2016-11-17 19:18:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509113004/20001
4 years, 1 month ago (2016-11-17 19:28:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/334187)
4 years, 1 month ago (2016-11-17 23:25:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509113004/20001
4 years, 1 month ago (2016-11-17 23:35:35 UTC) #11
commit-bot: I haz the power
Failed to apply the patch.
4 years, 1 month ago (2016-11-18 01:20:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509113004/20001
4 years, 1 month ago (2016-11-18 17:11:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 17:40:00 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 17:41:56 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8934714bb524f1a32b6d5434fea0ac59660cf6ff
Cr-Commit-Position: refs/heads/master@{#433228}

Powered by Google App Engine
This is Rietveld 408576698