Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2509113002: Use StreamUtil#closeQuietly to close a stream in MediaPlayerBridge (Closed)

Created:
4 years, 1 month ago by watk
Modified:
4 years, 1 month ago
Reviewers:
tguilbert
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StreamUtil#closeQuietly to close a stream in MediaPlayerBridge This is cleaner and will suppress a findbugs warning we had. BUG=665788 Committed: https://crrev.com/e32c210161618089232df9572b56d41a18d5e8a8 Cr-Commit-Position: refs/heads/master@{#432674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaPlayerBridge.java View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tguilbert
On 2016/11/16 22:12:51, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 1 month ago (2016-11-16 22:29:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509113002/1
4 years, 1 month ago (2016-11-16 22:33:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 00:22:45 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 00:32:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e32c210161618089232df9572b56d41a18d5e8a8
Cr-Commit-Position: refs/heads/master@{#432674}

Powered by Google App Engine
This is Rietveld 408576698