Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2509093002: Try focusing embeddedObject first unconditionally (Closed)

Created:
4 years, 1 month ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try focusing embeddedObject first unconditionally We attempt, on each navigation, to focus an unfocused embeddedObject for which we are entering (i.e. the embeddedObject is an ancestor). During this process, we might have exited early if we encountered a focused range. Ensure we always check for embeddedObject's to focus. TEST=navigate in OOBE sign in screen via tab/Search+left/right. Ensure we're getting focus inside of the webview e.g. type into the text field, navigate outside to the shutdown button, navigate back into the webview, type more into the email text field and verify stuff works. BUG=660390 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3d0aa6a69b15dadb70ecbff3428e55589966bbbc Cr-Commit-Position: refs/heads/master@{#432684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
David Tseng
4 years, 1 month ago (2016-11-16 21:26:01 UTC) #4
dmazzoni
lgtm
4 years, 1 month ago (2016-11-16 21:42:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509093002/1
4 years, 1 month ago (2016-11-16 22:08:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 01:41:41 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 01:48:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d0aa6a69b15dadb70ecbff3428e55589966bbbc
Cr-Commit-Position: refs/heads/master@{#432684}

Powered by Google App Engine
This is Rietveld 408576698