Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2509083002: Adding an explicit listener for the VR mode close button (Closed)

Created:
4 years, 1 month ago by bajones
Modified:
4 years, 1 month ago
Reviewers:
Ted C, mthiesse, bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding an explicit listener for the VR mode close button Prevents Chrome from shutting down when it's clicked, makes it use the same code path as pressing the back button. BUG=389343 Committed: https://crrev.com/827186acc62b6ee503dfef5865b14a01b522fdde Cr-Commit-Position: refs/heads/master@{#432664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
bajones
PTAL
4 years, 1 month ago (2016-11-16 21:03:51 UTC) #2
mthiesse
lgtm
4 years, 1 month ago (2016-11-16 21:33:44 UTC) #3
bajones
Thanks mthiesse@! tedchoc@: OWNER review please? It's a pretty simple change.
4 years, 1 month ago (2016-11-16 21:45:48 UTC) #5
bshe
On 2016/11/16 21:33:44, mthiesse wrote: > lgtm lgtm
4 years, 1 month ago (2016-11-16 21:47:40 UTC) #6
Ted C
lgtm
4 years, 1 month ago (2016-11-16 22:06:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509083002/1
4 years, 1 month ago (2016-11-16 22:08:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 23:47:02 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 23:56:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/827186acc62b6ee503dfef5865b14a01b522fdde
Cr-Commit-Position: refs/heads/master@{#432664}

Powered by Google App Engine
This is Rietveld 408576698