Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 250903002: Take grit_rc_header_format into account in grit actions that don't use build/grit_action.gypi. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, vsevik, dsinclair+watch_chromium.org, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Take grit_rc_header_format into account in grit actions that don't use build/grit_action.gypi. BUG=338759 TBR=nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266476

Patch Set 1 #

Patch Set 2 : add default variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/browser/devtools/devtools_resources.gyp View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/tracing/tracing_resources.gyp View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
Lei Zhang
This is probably why I see so many resources removed on Linux that shouldn't be. ...
6 years, 8 months ago (2014-04-25 08:37:30 UTC) #1
aurimas (slooooooooow)
Good catch! LGTM I missed devtools because they don't get included with stable Android builds ...
6 years, 8 months ago (2014-04-25 16:20:29 UTC) #2
aurimas (slooooooooow)
+nduca for review of content/browser/tracing/tracing_resources.gyp
6 years, 8 months ago (2014-04-25 16:27:33 UTC) #3
pfeldman
devtools lgtm
6 years, 8 months ago (2014-04-25 16:28:30 UTC) #4
Lei Zhang
On 2014/04/25 16:27:33, aurimas wrote: > +nduca for review of content/browser/tracing/tracing_resources.gyp TBRing since it's consistent ...
6 years, 8 months ago (2014-04-25 18:37:42 UTC) #5
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-25 18:37:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/250903002/1
6 years, 8 months ago (2014-04-25 22:12:05 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:30:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-25 23:30:32 UTC) #9
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-25 23:45:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/250903002/20001
6 years, 8 months ago (2014-04-25 23:46:36 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 06:27:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 06:27:19 UTC) #13
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-26 16:49:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/250903002/20001
6 years, 8 months ago (2014-04-26 16:50:46 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 21:52:27 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 21:52:27 UTC) #17
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-26 22:09:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/250903002/20001
6 years, 8 months ago (2014-04-26 22:10:25 UTC) #19
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 07:41:06 UTC) #20
Message was sent while issue was closed.
Change committed as 266476

Powered by Google App Engine
This is Rietveld 408576698