Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2509023002: Call super on setUp (Closed)

Created:
4 years, 1 month ago by amaralp
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call super on ContentShellTestBase#setUp The CL (crrev.com/2465053002) forgot to add a call to |super.setUp()| when it overrode |setUp()|. BUG=665813 Committed: https://crrev.com/085701ef9a4ad12ba89368704c4f92f6d8dbccfe Cr-Commit-Position: refs/heads/master@{#432612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
amaralp
PTAL
4 years, 1 month ago (2016-11-16 20:07:04 UTC) #7
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-16 20:19:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2509023002/1
4 years, 1 month ago (2016-11-16 20:22:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 20:35:30 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 20:55:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/085701ef9a4ad12ba89368704c4f92f6d8dbccfe
Cr-Commit-Position: refs/heads/master@{#432612}

Powered by Google App Engine
This is Rietveld 408576698