Issue 2509001: Refactor CommandBufferHelper to use Jump to loop...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2509001: Refactor CommandBufferHelper to use Jump to loop... (Closed)

Created:
10 years, 6 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactor CommandBufferHelper to use Jump to loop instead of Noop. This makes it actually work if you tell the command buffer helper to use less than the entire command buffer. TEST=modified unit tests and ran GLES2 conformance tests. BUG=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48835

Patch Set 1 #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -42 lines)			Patch
M	gpu/command_buffer/client/cmd_buffer_helper.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/client/cmd_buffer_helper.cc	View	5 chunks	+21 lines, -20 lines	0 comments	Download
M	gpu/command_buffer/client/cmd_buffer_helper_test.cc	View	13 chunks	+48 lines, -19 lines	2 comments	Download
M	gpu/command_buffer/service/cmd_parser.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

10 years, 6 months ago (2010-06-02 22:24:43 UTC) #2

LGTM

http://codereview.chromium.org/2509001/diff/1/4
File gpu/command_buffer/client/cmd_buffer_helper_test.cc (right):

http://codereview.chromium.org/2509001/diff/1/4#newcode115
gpu/command_buffer/client/cmd_buffer_helper_test.cc:115: //       
.InSequence(sequence_)
Uncomment or delete line?

http://codereview.chromium.org/2509001/diff/1/4#newcode164
gpu/command_buffer/client/cmd_buffer_helper_test.cc:164: //  Sequence sequence_;
Uncomment or delete line?

Expand Messages | Collapse Messages