Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2508973007: [ObjC ARC] Converts ios/testing/earl_grey:earl_grey_support to ARC.Automatically generated ARCMig… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
Reviewers:
baxley
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/testing/earl_grey:earl_grey_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/fa554a4b832c0d1b826da1fca37c7dec2c20cce0 Cr-Commit-Position: refs/heads/master@{#435241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/testing/earl_grey/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/testing/earl_grey/matchers.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. Passes downstream bots.
4 years ago (2016-11-24 17:18:08 UTC) #6
baxley
lgtm
4 years ago (2016-11-28 21:48:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508973007/1
4 years ago (2016-11-30 12:35:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 13:31:28 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-30 13:36:29 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa554a4b832c0d1b826da1fca37c7dec2c20cce0
Cr-Commit-Position: refs/heads/master@{#435241}

Powered by Google App Engine
This is Rietveld 408576698