Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2508973005: Un-deprecate some deprecated code and fix a couple of hints (Closed)

Created:
4 years, 1 month ago by Brian Wilkerson
Modified:
4 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Un-deprecate some deprecated code and fix a couple of hints R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/138cebfa2d57163af9e7e2e64aec9a11636cec36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M pkg/analyzer/lib/src/context/builder.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_byte_store.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 1 month ago (2016-11-17 19:39:07 UTC) #2
Paul Berry
lgtm
4 years, 1 month ago (2016-11-17 20:19:47 UTC) #3
Brian Wilkerson
4 years, 1 month ago (2016-11-17 20:34:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
138cebfa2d57163af9e7e2e64aec9a11636cec36 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698