Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2508953003: WTF: Add comments and tests for Unicode aware case-insensitive string operations. (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WTF: Add comments and tests for Unicode aware case-insensitive string operations. Also, this CL removes unused |equalIgnoringCase(const StringBuilder&, const StringType&)|. This CL has no behavior changes. BUG=627682 Committed: https://crrev.com/9a27ccab310b93cb3a70710833a51eb288ad475f Cr-Commit-Position: refs/heads/master@{#432962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -26 lines) Patch
M third_party/WebKit/Source/wtf/text/AtomicString.h View 2 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringBuilder.h View 2 chunks +3 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 3 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringView.h View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFStringTest.cpp View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
tkent
yutak@, would you review this please?
4 years, 1 month ago (2016-11-17 06:45:49 UTC) #4
Yuta Kitamura
LGTM I even might append "UnicodeCase" or something like that to each of those names ...
4 years, 1 month ago (2016-11-17 11:24:20 UTC) #8
tkent
On 2016/11/17 at 11:24:20, yutak wrote: > LGTM > > I even might append "UnicodeCase" ...
4 years, 1 month ago (2016-11-17 21:09:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508953003/1
4 years, 1 month ago (2016-11-17 21:10:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 21:29:01 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 21:32:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a27ccab310b93cb3a70710833a51eb288ad475f
Cr-Commit-Position: refs/heads/master@{#432962}

Powered by Google App Engine
This is Rietveld 408576698