Implement the generate-kernel api by invoking dartk. Add example that uses this API to generate a by

Implement the generate-kernel api by invoking dartk. Add example that uses this API to generate a byte buffer with the results.

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/d79ef86af73a2ce4a2ef6c8c196e2dc597d6f7ec

[Siggi Cherem (dart-lang), 2016-11-17 00:04:10]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2016-12-04 05:25:05]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2016-12-04 05:25:10]

Patchset #1 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2016-12-04 05:25:16]

Patchset #1 (id:60001) has been deleted

[Siggi Cherem (dart-lang), 2016-12-04 05:26:05]

Description was changed from

==========
(not ready to submit) example API to generate kernel binary ast in memory
==========

to

==========
Implement the generate-kernel api by invoking dartk. Add example that uses this
API to generate a byte buffer with the results.
==========

[Siggi Cherem (dart-lang), 2016-12-04 05:27:05]

sigmund@google.com changed reviewers:
+ paulberry@google.com

[Siggi Cherem (dart-lang), 2016-12-04 05:27:06]

I still have to add unit tests, but here is the patch after rebasing.

[Paul Berry, 2016-12-04 09:09:52]

lgtm.  I'd be fine with landing this as is--we can add unit tests and address my
review comments in follow-up CLs.

https://codereview.chromium.org/2508933003/diff/80001/pkg/front_end/lib/kerne...
File pkg/front_end/lib/kernel_generator.dart (right):

https://codereview.chromium.org/2508933003/diff/80001/pkg/front_end/lib/kerne...
pkg/front_end/lib/kernel_generator.dart:68: sources.forEach(loader.loadLibrary);
Does this work correctly if one of the sources is a part file?

https://codereview.chromium.org/2508933003/diff/80001/pkg/front_end/lib/kerne...
pkg/front_end/lib/kernel_generator.dart:82: DartOptions
_convertOptions(CompilerOptions options) {
How feasible would it be to get dartk to respect CompilerOptions.fileSystem?  It
would make unit testing easier, since we wouldn't have to have all of our unit
tests create temporary directories.

[Siggi Cherem (dart-lang), 2016-12-05 21:00:50]

thanks Paul!

https://codereview.chromium.org/2508933003/diff/80001/pkg/front_end/lib/kerne...
File pkg/front_end/lib/kernel_generator.dart (right):

https://codereview.chromium.org/2508933003/diff/80001/pkg/front_end/lib/kerne...
pkg/front_end/lib/kernel_generator.dart:68: sources.forEach(loader.loadLibrary);
On 2016/12/04 09:09:52, Paul Berry wrote:
> Does this work correctly if one of the sources is a part file?

Good point - I'll add a TODO, it doesn't crash but I don't believe it is doing
the right thing either.

https://codereview.chromium.org/2508933003/diff/80001/pkg/front_end/lib/kerne...
pkg/front_end/lib/kernel_generator.dart:82: DartOptions
_convertOptions(CompilerOptions options) {
On 2016/12/04 09:09:52, Paul Berry wrote:
> How feasible would it be to get dartk to respect CompilerOptions.fileSystem? 
It
> would make unit testing easier, since we wouldn't have to have all of our unit
> tests create temporary directories.

I believe it shouldn't take too much work to do so. Most IO is done via the
SourceFactory today. The only direct access to IO is for finding the .packages
file, but that should be easy to change.

[Siggi Cherem (dart-lang), 2016-12-05 21:02:30]

Description was changed from

==========
Implement the generate-kernel api by invoking dartk. Add example that uses this
API to generate a byte buffer with the results.
==========

to

==========
Implement the generate-kernel api by invoking dartk. Add example that uses this
API to generate a byte buffer with the results.

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d79ef86af73a2ce4a2ef6c8c196e2dc597d6f7ec
==========

[Siggi Cherem (dart-lang), 2016-12-05 21:02:31]

Committed patchset #1 (id:80001) manually as
d79ef86af73a2ce4a2ef6c8c196e2dc597d6f7ec (presubmit successful).