tools: Local tests for the speculative prefetch predictor.

chrome/common/chrome_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_switches.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "build/build_config.h"
 #include "ppapi/features/features.h"
@@ skipping 880 matching lines @@
 // Speculative resource prefetching.
 const char kSpeculativeResourcePrefetching[] =
     "speculative-resource-prefetching";
 
 // Speculative resource prefetching is disabled.
 const char kSpeculativeResourcePrefetchingDisabled[] = "disabled";
 
 // Speculative resource prefetching is enabled.
 const char kSpeculativeResourcePrefetchingEnabled[] = "enabled";
 
+// Speculative resource prefetching is enabled for external requests.
+const char kSpeculativeResourceExternalPrefetchingEnabled[] = "external";

[pasko, 2016/11/24 19:31:16]

following the pattern of the above two, it should be named more like:

kSpeculativeResourcePrefetchingExternal

or:

kSpeculativeResourcePrefetchingExternalOnly

[pasko, 2016/11/24 19:31:16]

nit: From naming it is not obvious whether "external" enables a subset of
functionality provided by "enabled"? We could name it so it would be more
obvious, like:

"enabled"
"enabled-external-only"

or:

"enabled-all"
"enabled-external"

[Benoit L, 2016/11/30 12:08:27]

Done.

[Benoit L, 2016/11/30 12:08:27]

Done.

+
 // Speculative resource prefetching will only learn about resources that need to
 // be prefetched but will not prefetch them.
 const char kSpeculativeResourcePrefetchingLearning[] = "learning";
 
 // Causes SSL key material to be logged to the specified file for debugging
 // purposes. See
 // https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/Key_Log_Format
 // for the format.
 const char kSSLKeyLogFile[]               = "ssl-key-log-file";
 
@@ skipping 407 matching lines @@
 
 // -----------------------------------------------------------------------------
 // DO NOT ADD YOUR VERY NICE FLAGS TO THE BOTTOM OF THIS FILE.
 //
 // You were going to just dump your switches here, weren't you? Instead, please
 // put them in alphabetical order above, or in order inside the appropriate
 // ifdef at the bottom. The order should match the header.
 // -----------------------------------------------------------------------------
 
 }  // namespace switches