VM: Fix libdart_lib_nosnapshot_precompiled_runtime build target.

VM: Fix libdart_lib_nosnapshot_precompiled_runtime build target.

TBR=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/8b123831e5d91beeb00b91ff4fba55bf464b2949

[Vyacheslav Egorov (Google), 2016-11-16 15:08:07]

Description was changed from

==========
VM: Fix libdart_lib_nosnapshot_precompiled_runtime build target.

BUG=
==========

to

==========
VM: Fix libdart_lib_nosnapshot_precompiled_runtime build target.

TBR=zra@google.com
==========

[Vyacheslav Egorov (Google), 2016-11-16 15:08:07]

vegorov@google.com changed reviewers:
+ zra@google.com

[Vyacheslav Egorov (Google), 2016-11-16 15:10:26]

Zach, 

I am not completely sure why this target even exists. 

DART_PRECOMPILED_RUNTIME implies no compiler, so it's unclear why would it ever
have no snapshot and how things are supposed to work in this setup (you have
precompiled code but bootstrap libraries from source files?).

Maybe this target can be removed?

[Vyacheslav Egorov (Google), 2016-11-16 15:11:12]

Description was changed from

==========
VM: Fix libdart_lib_nosnapshot_precompiled_runtime build target.

TBR=zra@google.com
==========

to

==========
VM: Fix libdart_lib_nosnapshot_precompiled_runtime build target.

TBR=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8b123831e5d91beeb00b91ff4fba55bf464b2949
==========

[Vyacheslav Egorov (Google), 2016-11-16 15:11:14]

Committed patchset #1 (id:1) manually as
8b123831e5d91beeb00b91ff4fba55bf464b2949 (presubmit successful).

[jeffbrown, 2016-11-16 15:17:07]

jeffbrown@google.com changed reviewers:
+ jeffbrown@google.com

[jeffbrown, 2016-11-16 15:17:07]

I'm sorry, it's still broken.  :(

[752/2348] CXX
obj/dart/runtime/vm/libdart_vm_nosnapshot_precompiled_runtime.object.o
FAILED: obj/dart/runtime/vm/libdart_vm_nosnapshot_precompiled_runtime.object.o 
../../buildtools/toolchain/clang+llvm-x86_64-linux/bin/clang++ -MMD -MF
obj/dart/runtime/vm/libdart_vm_nosnapshot_precompiled_runtime.object.o.d
-DSYSROOT_VERSION=aefe73263dc37a2166e2686523eef4d804a39467 -DNDEBUG
-DDART_PRECOMPILED_RUNTIME -DDART_NO_SNAPSHOT -I../../dart/runtime -I../.. -Igen
-g --sysroot=../sysroot/x86_64-fuchsia --target=x86_64-fuchsia -Werror -Wall
-Wextra -Wno-unused-parameter -g -O0 -Werror -Wall -Wextra -Wno-unused-parameter
-Wnon-virtual-dtor -Wvla -Wno-conversion-null -Woverloaded-virtual -g3 -ggdb3
-fno-rtti -fno-exceptions -O3 -fvisibility-inlines-hidden -std=c++14
-fno-exceptions -fno-rtti -c ../../dart/runtime/vm/object.cc -o
obj/dart/runtime/vm/libdart_vm_nosnapshot_precompiled_runtime.object.o
../../dart/runtime/vm/object.cc:11378:27: error: expected expression
  CORE_LIB_INTRINSIC_LIST(CHECK_FINGERPRINTS2);
                          ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_Smi'
  CORE_LIB_INTRINSIC_LIST(CHECK_FINGERPRINTS2);
  ^
../../dart/runtime/vm/method_recognizer.h:139:5: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Smi, ~, Smi_bitNegate, Smi, 0x63bfee11)                                   \
    ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'Smi_bitNegate'; did you mean 'MethodRecognizer::kSmi_bitNegate'?
../../dart/runtime/vm/method_recognizer.h:139:14: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Smi, ~, Smi_bitNegate, Smi, 0x63bfee11)                                   \
             ^
../../dart/runtime/vm/method_recognizer.h:510:21: note:
'MethodRecognizer::kSmi_bitNegate' declared here
    RECOGNIZED_LIST(DEFINE_ENUM_LIST)
                    ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_Smi'
  CORE_LIB_INTRINSIC_LIST(CHECK_FINGERPRINTS2);
  ^
../../dart/runtime/vm/method_recognizer.h:140:5: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Smi, get:bitLength, Smi_bitLength, Smi, 0x25b2e24c)                       \
    ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'get'
../../dart/runtime/vm/method_recognizer.h:140:11: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Smi, get:bitLength, Smi_bitLength, Smi, 0x25b2e24c)                       \
          ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_Smi'
../../dart/runtime/vm/method_recognizer.h:141:5: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Smi, _bitAndFromSmi, Smi_bitAndFromSmi, Smi, 0x0df806ed)                  \
    ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_bitAndFromSmi'
../../dart/runtime/vm/method_recognizer.h:141:11: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Smi, _bitAndFromSmi, Smi_bitAndFromSmi, Smi, 0x0df806ed)                  \
          ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'Smi_bitAndFromSmi'
../../dart/runtime/vm/method_recognizer.h:141:27: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Smi, _bitAndFromSmi, Smi_bitAndFromSmi, Smi, 0x0df806ed)                  \
                          ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_lsh'; did you mean 'else'?
../../dart/runtime/vm/method_recognizer.h:142:14: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _lsh, Bigint_lsh, Dynamic, 0x5cd95513)                            \
             ^
../../dart/runtime/vm/object.cc:11378:3: error: expected expression
../../dart/runtime/vm/method_recognizer.h:142:14: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _lsh, Bigint_lsh, Dynamic, 0x5cd95513)                            \
             ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_Bigint'
../../dart/runtime/vm/method_recognizer.h:142:5: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _lsh, Bigint_lsh, Dynamic, 0x5cd95513)                            \
    ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'Bigint_lsh'; did you mean 'MethodRecognizer::kBigint_lsh'?
../../dart/runtime/vm/method_recognizer.h:142:20: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _lsh, Bigint_lsh, Dynamic, 0x5cd95513)                            \
                   ^
../../dart/runtime/vm/method_recognizer.h:510:21: note:
'MethodRecognizer::kBigint_lsh' declared here
    RECOGNIZED_LIST(DEFINE_ENUM_LIST)
                    ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_Bigint'
  CORE_LIB_INTRINSIC_LIST(CHECK_FINGERPRINTS2);
  ^
../../dart/runtime/vm/method_recognizer.h:143:5: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _rsh, Bigint_rsh, Dynamic, 0x2d68d0e1)                            \
    ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_rsh'
../../dart/runtime/vm/method_recognizer.h:143:14: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _rsh, Bigint_rsh, Dynamic, 0x2d68d0e1)                            \
             ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'Bigint_rsh'
../../dart/runtime/vm/method_recognizer.h:143:20: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _rsh, Bigint_rsh, Dynamic, 0x2d68d0e1)                            \
                   ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_Bigint'
../../dart/runtime/vm/method_recognizer.h:144:5: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _absAdd, Bigint_absAdd, Dynamic, 0x492f4865)                      \
    ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_absAdd'
../../dart/runtime/vm/method_recognizer.h:144:14: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _absAdd, Bigint_absAdd, Dynamic, 0x492f4865)                      \
             ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'Bigint_absAdd'
../../dart/runtime/vm/method_recognizer.h:144:23: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _absAdd, Bigint_absAdd, Dynamic, 0x492f4865)                      \
                      ^
../../dart/runtime/vm/object.cc:11378:3: error: use of undeclared identifier
'_Bigint'
../../dart/runtime/vm/method_recognizer.h:145:5: note: expanded from macro
'CORE_LIB_INTRINSIC_LIST'
  V(_Bigint, _absSub, Bigint_absSub, Dynamic, 0x174a3a34)                      \
    ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
[791/2348] CXX obj/dart/runtime/vm/libdart_vm.object.o

[Vyacheslav Egorov (Google), 2016-11-16 15:26:46]

Ok, can repro this with

$ ninja -C out/ReleaseX64 libdart_nosnapshot_precompiled_runtime

I will wait for Zach chime in on why we have this target to begin with. I think
it should be removed. 

libdart_nosnapshot_precompiled_runtime makes no sense to me.

[zra, 2016-11-16 15:51:07]

On 2016/11/16 15:26:46, Vyacheslav Egorov (Google) wrote:
> Ok, can repro this with
> 
> $ ninja -C out/ReleaseX64 libdart_nosnapshot_precompiled_runtime
> 
> I will wait for Zach chime in on why we have this target to begin with. I
think
> it should be removed. 
> 
> libdart_nosnapshot_precompiled_runtime makes no sense to me.

I'm not sure why we have it either. I think it can be safely removed.