Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2508873003: Kill any lingering spawning test server on Android when handling /start (Closed)

Created:
4 years, 1 month ago by eroman
Modified:
4 years, 1 month ago
Reviewers:
jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Kill any lingering spawning test server on Android when handling /start BUG=665686 Committed: https://crrev.com/75b27526ecaf8fe51b180639e2c9a46b87613dd9 Cr-Commit-Position: refs/heads/master@{#432788}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/android/pylib/chrome_test_server_spawner.py View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
eroman
4 years, 1 month ago (2016-11-17 00:45:39 UTC) #4
jbudorick
lgtm
4 years, 1 month ago (2016-11-17 00:52:04 UTC) #5
eroman
I made some changes, please see patchset #2
4 years, 1 month ago (2016-11-17 01:05:15 UTC) #6
jbudorick
ah, right, i suppose you wouldn't want to try to communicate to the device in ...
4 years, 1 month ago (2016-11-17 01:07:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508873003/20001
4 years, 1 month ago (2016-11-17 02:15:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on ...
4 years, 1 month ago (2016-11-17 03:17:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508873003/20001
4 years, 1 month ago (2016-11-17 05:55:17 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 06:48:39 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 06:50:20 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75b27526ecaf8fe51b180639e2c9a46b87613dd9
Cr-Commit-Position: refs/heads/master@{#432788}

Powered by Google App Engine
This is Rietveld 408576698