Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2508873002: [turbofan] Always install code dependency when optimizing a store to global property. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Always install code dependency when optimizing a store to global property. The reason is that non-configurability still allows a writable property to become read-only. BUG=chromium:663750 Committed: https://crrev.com/446d6a067890b2f8310ce95885b41b2410193e0e Cr-Commit-Position: refs/heads/master@{#41029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M src/compiler/js-global-object-specialization.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-663750.js View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-16 11:31:40 UTC) #4
Benedikt Meurer
lgtm
4 years, 1 month ago (2016-11-16 11:32:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508873002/1
4 years, 1 month ago (2016-11-16 11:34:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 12:02:13 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:36:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/446d6a067890b2f8310ce95885b41b2410193e0e
Cr-Commit-Position: refs/heads/master@{#41029}

Powered by Google App Engine
This is Rietveld 408576698