Invalidate shape cache when accept languages change

Invalidate shape cache when accept languages change

Shape Cache in Font need to be invalidated when accept languages
change.

BUG=665768
Committed: https://crrev.com/e1c6b40e73bbc055cae403c22ef53a9a4415c091
Cr-Commit-Position: refs/heads/master@{#432834}

[Yirui Huang, 2016-11-16 08:39:33]

yirui@google.com changed reviewers:
+ kojii@chromium.org

[Yirui Huang, 2016-11-16 08:39:33]

Please let me know if more specific description is needed.

[kojii, 2016-11-16 16:23:14]

kojii@chromium.org changed reviewers:
+ drott@chromium.org

[kojii, 2016-11-16 16:23:15]

non-owner LGTM, thank you for working on this.

drott@, PTAL.

Some background; yirui@ is working on synchronizing Android system locale list
to accept language list, including multi-locale support on N. Before her work,
accept language list on Android was hard coded to "en". This not only sends
correct HTTP header to server, but also helps choosing the correct font since we
use it for the system font fallback too.

We found we already invalidate shape cache when generic font family settings was
changed:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Style...

but I missed to do this when the accept language list was changed.

[drott, 2016-11-17 08:31:53]

LGTM

[Yirui Huang, 2016-11-17 08:32:17]

The CQ bit was checked by yirui@google.com

[commit-bot: I haz the power, 2016-11-17 08:32:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 08:40:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:40:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yirui Huang, 2016-11-17 08:55:34]

The CQ bit was checked by yirui@google.com

[Yirui Huang, 2016-11-17 08:55:35]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org,
kojii@chromium.org
Link to the patchset: https://codereview.chromium.org/2508843002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-11-17 08:55:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-11-17 08:59:09]

It looks like the build is broken now. Hopefully it goes well this time, if not,
just wait for a few hours and commit again. Still LGTM.

[commit-bot: I haz the power, 2016-11-17 10:36:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 10:39:37]

Description was changed from

==========
Invalidate shape cache when accept languages change

Shape Cache in Font need to be invalidated when accept languages
change.

BUG=665768
==========

to

==========
Invalidate shape cache when accept languages change

Shape Cache in Font need to be invalidated when accept languages
change.

BUG=665768

Committed: https://crrev.com/e1c6b40e73bbc055cae403c22ef53a9a4415c091
Cr-Commit-Position: refs/heads/master@{#432834}
==========

[commit-bot: I haz the power, 2016-11-17 10:39:38]

Patchset 2 (id:??) landed as
https://crrev.com/e1c6b40e73bbc055cae403c22ef53a9a4415c091
Cr-Commit-Position: refs/heads/master@{#432834}