Issue 250883005: Oilpan: fix build after r172658.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250883005: Oilpan: fix build after r172658. (Closed)

Created:
6 years, 8 months ago by sof

Modified:
6 years, 8 months ago

Reviewers:
oilpan-reviews, tkent, haraken

CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, kinuko, falken, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: fix build after r172658. DOMExceptions aren't yet on the Oilpan heap; adjust transition types accordingly in ServiceWorkerError. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172676

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/modules/serviceworkers/ServiceWorkerError.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/modules/serviceworkers/ServiceWorkerError.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sof

Please take a look. (Fixing the build first; DOMException should probably be moved to the ...

6 years, 8 months ago (2014-04-25 21:27:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/250883005/1

6 years, 8 months ago (2014-04-25 22:33:57 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages