Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 250883003: Add GYP variable for disabling sanitizer_options. (Closed)

Created:
6 years, 8 months ago by kjellander_chromium
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add GYP variable for disabling sanitizer_options. In https://codereview.chromium.org/238123003 an import of base.gyp is introduced in build/common.gypi. This makes GYP fail for some client projects using the Chromium build toolchain. By adding a condition variable for this part, it is possible to avoid this include by setting use_sanitizer_options=0. NOTRY=True BUG=302040 TEST=passing runhooks on a variety of trybots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/common.gypi View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kjellander_chromium
6 years, 8 months ago (2014-04-25 08:31:01 UTC) #1
Alexander Potapenko
LGTM
6 years, 8 months ago (2014-04-25 08:44:03 UTC) #2
kjellander_chromium
The CQ bit was checked by kjellander@chromium.org
6 years, 8 months ago (2014-04-25 19:19:15 UTC) #3
kjellander_chromium
The CQ bit was unchecked by kjellander@chromium.org
6 years, 8 months ago (2014-04-25 19:49:56 UTC) #4
kjellander_chromium
The CQ bit was checked by kjellander@chromium.org
6 years, 7 months ago (2014-04-28 05:48:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/250883003/1
6 years, 7 months ago (2014-04-28 05:49:16 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 12:11:22 UTC) #7
Message was sent while issue was closed.
Change committed as 266514

Powered by Google App Engine
This is Rietveld 408576698