src/object-observe.js - Issue 250883002: Fix |RunMicrotasks()| leaking reference to the last context being run on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/object-observe.js

Issue 250883002: Fix |RunMicrotasks()| leaking reference to the last context being run on. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: remove external_ Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/object-observe.js

diff --git a/src/object-observe.js b/src/object-observe.js

index c4ddd181d2841c479c3de34bd6d683554e2352bd..71eb6566083e96c306ab66cd13e8b35bca721751 100644

--- a/src/object-observe.js

+++ b/src/object-observe.js

@@ -434,8 +434,7 @@ function ObserverEnqueueIfActive(observer, objectInfo, changeRecord,

var callbackInfo = CallbackInfoNormalize(callback);

if (IS_NULL(GetPendingObservers())) {

SetPendingObservers(nullProtoObject())

- GetMicrotaskQueue().push(ObserveMicrotaskRunner);

- %SetMicrotaskPending(true);

+ EnqueueMicrotask(ObserveMicrotaskRunner);

}

GetPendingObservers()[callbackInfo.priority] = callback;

callbackInfo.push(changeRecord);

« no previous file with comments | « src/execution.cc ('k') | src/promise.js » ('j') | no next file with comments »