Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2508803010: Treat APKs as dangerous on Linux as well as on Android. (Closed)

Created:
4 years, 1 month ago by palmer
Modified:
4 years, 1 month ago
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Treat APKs as dangerous on Linux as well as on Android. BUG=666824 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/49d4920a95c5f0796a4bfc807c66311b9134fee6 Cr-Commit-Position: refs/heads/master@{#433376}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incremented the version_id. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/resources/safe_browsing/download_file_types.asciipb View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
palmer
asanka, jialiul, nparker: Quick and easy review for you.
4 years, 1 month ago (2016-11-18 22:53:20 UTC) #3
Jialiu Lin
https://codereview.chromium.org/2508803010/diff/1/chrome/browser/resources/safe_browsing/download_file_types.asciipb File chrome/browser/resources/safe_browsing/download_file_types.asciipb (right): https://codereview.chromium.org/2508803010/diff/1/chrome/browser/resources/safe_browsing/download_file_types.asciipb#newcode11 chrome/browser/resources/safe_browsing/download_file_types.asciipb:11: version_id: 7 Please increment the version_id, otherwise component update ...
4 years, 1 month ago (2016-11-18 23:11:51 UTC) #6
asanka
No objections from me. I'll defer to jialiul. https://codereview.chromium.org/2508803010/diff/1/chrome/browser/resources/safe_browsing/download_file_types.asciipb File chrome/browser/resources/safe_browsing/download_file_types.asciipb (right): https://codereview.chromium.org/2508803010/diff/1/chrome/browser/resources/safe_browsing/download_file_types.asciipb#newcode11 chrome/browser/resources/safe_browsing/download_file_types.asciipb:11: version_id: ...
4 years, 1 month ago (2016-11-18 23:15:03 UTC) #7
palmer
> Please increment the version_id, otherwise component update doesn't work. Done.
4 years, 1 month ago (2016-11-18 23:18:15 UTC) #8
Jialiu Lin
lgtm
4 years, 1 month ago (2016-11-18 23:18:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508803010/20001
4 years, 1 month ago (2016-11-18 23:22:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-19 01:56:01 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 01:59:20 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49d4920a95c5f0796a4bfc807c66311b9134fee6
Cr-Commit-Position: refs/heads/master@{#433376}

Powered by Google App Engine
This is Rietveld 408576698