Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: media/capture/video/linux/video_capture_device_linux.h

Issue 2508803002: Rotate frames correctly for back camera (Closed)
Patch Set: remove unused header Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/linux/video_capture_device_linux.h
diff --git a/media/capture/video/linux/video_capture_device_linux.h b/media/capture/video/linux/video_capture_device_linux.h
index e8adbde8df41715bdd075c0c921c3f6446eb4383..b8275063932a576dc07019e647c669a89d71c4c2 100644
--- a/media/capture/video/linux/video_capture_device_linux.h
+++ b/media/capture/video/linux/video_capture_device_linux.h
@@ -50,6 +50,9 @@ class VideoCaptureDeviceLinux : public VideoCaptureDevice {
private:
static int TranslatePowerLineFrequencyToV4L2(PowerLineFrequency frequency);
+ // Return true if the camera is back-facing.
+ bool GetCameraFacing(const VideoCaptureDeviceDescriptor& device_descriptor);
+
// Internal delegate doing the actual capture setting, buffer allocation and
// circulation with the V4L2 API. Created and deleted in the thread where
// VideoCaptureDeviceLinux lives but otherwise operating on |v4l2_thread_|.
@@ -59,6 +62,8 @@ class VideoCaptureDeviceLinux : public VideoCaptureDevice {
const VideoCaptureDeviceDescriptor device_descriptor_;
+ bool is_back_camera_;
wuchengli 2016/11/16 12:15:19 I think we need three states -- back facing, front
shenghao 2016/11/17 08:41:44 But what we really cares is whether it is a back c
wuchengli 2016/11/17 09:26:04 OK. Let's document it then. // True if the camera
shenghao 2016/11/17 10:15:55 Done.
+
DISALLOW_IMPLICIT_CONSTRUCTORS(VideoCaptureDeviceLinux);
};

Powered by Google App Engine
This is Rietveld 408576698