Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1775)

Unified Diff: media/capture/video/linux/video_capture_device_chromeos.h

Issue 2508803002: Rotate frames correctly for back camera (Closed)
Patch Set: move from linux to chromeos Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/linux/video_capture_device_chromeos.h
diff --git a/media/capture/video/linux/video_capture_device_chromeos.h b/media/capture/video/linux/video_capture_device_chromeos.h
index cd33a5cda0ac270c90554aff0b3af1eace54ead4..a61b6bd7cd50ecf922c2ad01e4363616e296263b 100644
--- a/media/capture/video/linux/video_capture_device_chromeos.h
+++ b/media/capture/video/linux/video_capture_device_chromeos.h
@@ -5,7 +5,9 @@
#ifndef MEDIA_CAPTURE_VIDEO_LINUX_VIDEO_CAPTURE_DEVICE_CHROMEOS_H_
#define MEDIA_CAPTURE_VIDEO_LINUX_VIDEO_CAPTURE_DEVICE_CHROMEOS_H_
+#include "base/lazy_instance.h"
#include "base/macros.h"
+#include "media/capture/video/linux/camera_characteristics.h"
#include "media/capture/video/linux/video_capture_device_linux.h"
namespace display {
@@ -24,11 +26,16 @@ class VideoCaptureDeviceChromeOS : public VideoCaptureDeviceLinux {
const VideoCaptureDeviceDescriptor& device_descriptor);
~VideoCaptureDeviceChromeOS() override;
+ protected:
+ void SetRotation(int rotation) override;
+
private:
class ScreenObserverDelegate;
void SetDisplayRotation(const display::Display& display);
scoped_refptr<ScreenObserverDelegate> screen_observer_delegate_;
+ int lens_facing_;
+ base::LazyInstance<CameraCharacteristics> camera_characteristics_;
kcwu 2016/11/24 15:48:52 This should be static or global, otherwise no poin
shenghao 2016/11/28 08:52:04 Done.
DISALLOW_IMPLICIT_CONSTRUCTORS(VideoCaptureDeviceChromeOS);
};

Powered by Google App Engine
This is Rietveld 408576698