Rotate frames correctly for back camera

media/capture/video/linux/camera_characteristics.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[mcasas, 2016/11/17 17:53:07]

No (c), here and in the .cc file.

[shenghao, 2016/11/21 06:24:53]

done

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_CAPTURE_VIDEO_LINUX_CAMERA_CHARACTERISTICS_H_
+#define MEDIA_CAPTURE_VIDEO_LINUX_CAMERA_CHARACTERISTICS_H_
+
+#include <stddef.h>
+#include <string>
+#include <vector>
+
+namespace media {
+
+// DeviceInfo can be found in /etc/camera/camera_characteristics.conf on device.
+struct DeviceInfo {
+  static const int LENS_FACING_FRONT = 0;

[kcwu, 2016/11/17 15:02:18]

enum ?

[shenghao, 2016/11/21 06:24:53]

I think it's better to use int here to match the values in config file. Using
enum needs another layer of conversion.

+  static const int LENS_FACING_BACK = 1;
+
+  std::string device_path;  // Ex. "/dev/video2"
+  std::string usb_vid;      // USB vender id
+  std::string usb_pid;      // USB product id
+  uint32_t
+      lens_facing;  // Direction the camera faces relative to device screen.

[kcwu, 2016/11/17 15:02:18]

You put some comment at the same line and some not. Please be consistent.

[shenghao, 2016/11/21 06:24:53]

Done.

+  // Clockwise angle through which the output image needs to be rotated to be
+  // upright on the device screen in its native orientation.
+  int32_t sensor_orientation;

[kcwu, 2016/11/17 15:02:18]

what is expected range? could it be negative?

[shenghao, 2016/11/21 06:24:53]

Done.

+  // There might be some corrupted frames at the beginning after stream on. We
+  // need to skip them.
+  uint32_t frames_to_skip_after_streamon;
+  float horizontal_view_angle_16_9;
+  float horizontal_view_angle_4_3;
+  std::vector<float> lens_info_available_focal_lengths;
+  float lens_info_minimum_focus_distance;
+  float lens_info_optimal_focus_distance;
+  float vertical_view_angle_16_9;
+  float vertical_view_angle_4_3;

[mcasas, 2016/11/17 17:53:07]

This structure has a number of fields, but IIUC
we only need a few for the purpose at hand: 
please remove all the not strictly necessary code.
Also see my comments further on.

[shenghao, 2016/11/21 06:24:53]

Done.

+};
+
+typedef std::vector<DeviceInfo> DeviceInfos;
+
+// CameraCharacteristics reads the file /etc/camera/camera_characteristics.conf

[kcwu, 2016/11/17 15:02:18]

oh, I found the comments here. but you only describe the assumptions, not
syntax.

[shenghao, 2016/11/21 06:24:53]

Isn't the example below enough to help readers understand the syntax?

[kcwu, 2016/11/21 07:59:24]

For example,
1. do you allow space before and after "=", trailing spaces ?
2. Are "cameraX" and "moduleX" names are required? Can they be free text? I have
this question because you didn't check their value now.
3. You need to explain A.key=value is applied to A.*.key. This is not trivial to
know from the syntax.

btw,
do you still need 256 limit since you use c++ string now?

+// and stores the content in |device_infos_|. There are several assumptions of
+// the config file:
+//  1. Each line should be at most 256 characters long.
+//  2. camera id should be in ascending order (i.e., 0, 1, 2, ...).
+//  3. usb_vid_pid should be the first subkey.
+//  4. All configs of a module should be put together.
+//
+// Example of the config file:
+//  camera0.lens_facing=0
+//  camera0.sensor_orientation=0
+//  camera0.module0.usb_vid_pid=0123:4567
+//  camera0.module0.horizontal_view_angle=68.4
+//  camera0.module0.lens_info_available_focal_lengths=1.64
+//  camera0.module0.lens_info_minimum_focus_distance=0.22
+//  camera0.module0.lens_info_optimal_focus_distance=0.5
+//  camera0.module0.vertical_view_angle=41.6
+//  camera0.module1.usb_vid_pid=89ab:cdef
+//  camera0.module1.lens_info_available_focal_lengths=1.69,2
+//  camera1.lens_facing=1
+//  camera1.sensor_orientation=180
+class CameraCharacteristics {
+ public:
+  CameraCharacteristics();
+  ~CameraCharacteristics();
+
+  // Parses /etc/camera/camera_characteristics.conf.
+  // Returns DeviceInfos with default characteristics if the config file doesn't
+  // exist.
+  const DeviceInfos GetCharacteristicsFromFile(
+      const std::vector<std::string>& devices);
+
+  // Get camera facing by specifying vid and pid. |model_id| should be formatted
+  // as "vid:pid".
+  // Returns DeviceInfo::LENS_FACING_FRONT or DeviceInfo::LENS_FACING_BACK.
+  // Default is DeviceInfo::LENS_FACING_FRONT.
+  int GetCameraFacing(const std::string& model_id);
+
+ private:
+  DeviceInfos device_infos_;
+
+  void AddPerCameraCharacteristic(uint32_t camera_id,
+                                  const char* characteristic,
+                                  const char* value);
+  void AddPerModuleCharacteristic(uint32_t camera_id,
+                                  const char* characteristic,
+                                  const char* value);
+  void AddFloatValue(const char* value,
+                     const char* characteristic_name,
+                     float* characteristic);
+};
+
+}  // namespace arc
+
+#endif  // MEDIA_CAPTURE_VIDEO_LINUX_CAMERA_CHARACTERISTICS_H_