GTTF: Restore a change that makes local testing possible.

commit-queue/tests/pending_manager_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for pending_manager.py."""
 
 import logging
 import os
 import re
@@ skipping 95 matching lines @@
             [ _try_comment(),
               'close_issue(%d)' % issue,
               "update_description(%d, u'foo')" % issue,
               "add_comment(%d, 'Change committed as 125')" % issue])
       else:
         self.context.checkout.check_calls(
             [ 'prepare(None)',
               'apply_patch(%r)' % (self.context.rietveld.patchsets[0],)])
         self.context.rietveld.check_calls(
             [ _try_comment(),
-              "set_flag(%d, 1, 'commit', 'False')" % issue,
+              "set_flag(%d, 1, 'commit', False)" % issue,
               "add_comment(%d, %r)" % (issue, pc.FAILED_NO_MESSAGE)])
     else:
       if success:
         self.context.checkout.check_calls(
           self._prepare_apply_commit(0, issue))
         self.context.rietveld.check_calls(
             [ _try_comment(),
               'close_issue(%d)' % issue,
               "update_description(%d, u'foo')" % issue,
               "add_comment(%d, 'Change committed as 125')" % issue])
       else:
         # checkout is never touched in that case.
         self.context.checkout.check_calls([])
         if defered:
           self.context.rietveld.check_calls(
               [ _try_comment(),
-                "set_flag(%d, 1, 'commit', 'False')" % issue,
+                "set_flag(%d, 1, 'commit', False)" % issue,
                 "add_comment(%d, %r)" % (issue, pc.FAILED_NO_MESSAGE)])
         else:
           self.context.rietveld.check_calls(
-              [ "set_flag(%d, 1, 'commit', 'False')" % issue,
+              [ "set_flag(%d, 1, 'commit', False)" % issue,
                 "add_comment(%d, %r)" % (issue, pc.FAILED_NO_MESSAGE)])
 
   def _prepare_apply_commit(self, index, issue, server_hooks_missing=False):
     """Returns a frequent sequence of action happening on the Checkout object.
 
     The list returned by this function should be used as an argument to
     self.context.checkout.check_calls().
     """
     seq = [
       # Reverts any previous modification or checkout the tree if it was not
@@ skipping 466 matching lines @@
     self.assertEqual(0, len(pc.queue.iterate()))
     pc.look_for_new_pending_commit()
     self.assertEqual(1, len(pc.queue.iterate()))
     # Pop the LGTM.
     pc.queue.iterate()[0].messages.pop(1)
     pc.process_new_pending_commit()
     self.assertEqual(0, len(pc.queue.iterate()))
     pc.update_status()
     self.assertEqual(0, len(pc.queue.iterate()))
     self.context.rietveld.check_calls(
-        [ "set_flag(%d, 1, 'commit', 'False')" % issue,
+        [ "set_flag(%d, 1, 'commit', False)" % issue,
           "add_comment(%d, %r)" % (issue, reviewer_lgtm.LgtmStatus.NO_LGTM)])
     self.context.status.check_names(['abort'])
 
   def testVerifyDefaultMockPlusLGTM(self):
     # Verify mock expectation with a single approval message.
     issue = 31337
     pc = self._get_pc_reviewer()
     self._approve()
     self.assertEqual(0, len(pc.queue.iterate()))
     pc.look_for_new_pending_commit()
@@ skipping 19 matching lines @@
     self._approve()
     pc.look_for_new_pending_commit()
     pc.process_new_pending_commit()
     pc.update_status()
     # A new reviewer prevents the commit.
     i = self.context.rietveld.issues[issue]
     i['reviewers'] = i['reviewers'] + ['annoying@dude.org']
     pc.scan_results()
     self.context.rietveld.check_calls(
         [ _try_comment(),
-          "set_flag(%d, 1, 'commit', 'False')" % issue,
+          "set_flag(%d, 1, 'commit', False)" % issue,
           ('add_comment(%d, "List of reviewers changed. annoying@dude.org '
               'did a drive-by without LGTM\'ing!")') % issue])
     self.context.status.check_names(['initial', 'abort'])
 
   def testDriveByLGTM(self):
     issue = 31337
     pc = self._get_pc_reviewer()
     self._approve()
     pc.look_for_new_pending_commit()
     pc.process_new_pending_commit()
@@ skipping 45 matching lines @@
     self.context.checkout.check_calls(
         self._prepare_apply_commit(0, issue))
 
 
 if __name__ == '__main__':
   logging.basicConfig(
       level=[logging.ERROR, logging.WARNING, logging.INFO, logging.DEBUG][
         min(sys.argv.count('-v'), 3)],
       format='%(levelname)5s %(module)15s(%(lineno)3d): %(message)s')
   unittest.main()