Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/core/clipboard/DataTransferItemList.idl

Issue 2508773005: DataTransferItemList#add() file argument should not be nullable (Closed)
Patch Set: Added layout tests for dataTransferItemList.add() Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/drag-dataTransferItemList-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/clipboard/DataTransferItemList.idl
diff --git a/third_party/WebKit/Source/core/clipboard/DataTransferItemList.idl b/third_party/WebKit/Source/core/clipboard/DataTransferItemList.idl
index bbdbc8e8a705151d2d1757ca38010efe7da155a6..a38c0578d1027f1cba0250e46eb39f2486129e91 100644
--- a/third_party/WebKit/Source/core/clipboard/DataTransferItemList.idl
+++ b/third_party/WebKit/Source/core/clipboard/DataTransferItemList.idl
@@ -34,8 +34,7 @@ interface DataTransferItemList {
readonly attribute unsigned long length;
[ImplementedAs=item] getter DataTransferItem (unsigned long index);
[RaisesException] DataTransferItem? add(DOMString data, DOMString type);
- // TODO(foolip): The file argument should not be nullable.
- DataTransferItem? add(File? file);
+ DataTransferItem? add(File file);
[RaisesException, ImplementedAs=deleteItem] void remove(unsigned long index);
void clear();
};
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/drag-dataTransferItemList-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698