Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2508743002: Changed EWhiteSpace to an enum class and renamed its members to keywords (Closed)

Created:
4 years, 1 month ago by sashab
Modified:
4 years, 1 month ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed EWhiteSpace to an enum class and renamed its members to keywords Changed EWhiteSpace to an enum class and gave it an unsigned underlying type. Also renamed its members to match its keywords from CSSValueKeywords.in. Changing it to an enum class enforces better namespacing and code practices. Adding the unsigned underlying type is pre-work for when the class is eventually stored as an enum bitfield (it would be done in this patch, except a presubmit warning already exists that prevents that. The presubmit warning needs to be updated before that change can occur.) This is also pre-work to move EWhiteSpace to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/521551f2e6bd230ff54adf9fdcdc4fd837598fd1 Cr-Commit-Position: refs/heads/master@{#433476}

Patch Set 1 #

Patch Set 2 : Fixed small probleatic file on mac #

Patch Set 3 : Small mac fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -53 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 2 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 4 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
sashab
4 years, 1 month ago (2016-11-16 05:55:32 UTC) #2
rune
lgtm
4 years, 1 month ago (2016-11-16 09:45:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508743002/1
4 years, 1 month ago (2016-11-17 02:33:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/307656)
4 years, 1 month ago (2016-11-17 03:13:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508743002/20001
4 years, 1 month ago (2016-11-17 04:53:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/307724)
4 years, 1 month ago (2016-11-17 05:26:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508743002/30001
4 years, 1 month ago (2016-11-21 03:30:34 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 1 month ago (2016-11-21 04:59:59 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 05:01:42 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/521551f2e6bd230ff54adf9fdcdc4fd837598fd1
Cr-Commit-Position: refs/heads/master@{#433476}

Powered by Google App Engine
This is Rietveld 408576698