Issue 250873003: Fix compilation with clang 5.1 on OS X.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250873003: Fix compilation with clang 5.1 on OS X. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer

Modified:
6 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
git@github.com:v8/v8.git@master

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/assembler.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/bootstrapper.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

Xcode's latest clang is really picky about unused fields.

6 years, 8 months ago (2014-04-25 10:46:27 UTC) #1

Sven Panne

LGTM. Follow-up CL which uses this is already on the way, but it's good to ...

6 years, 8 months ago (2014-04-25 11:03:32 UTC) #2

Sven Panne

6 years, 8 months ago (2014-04-25 11:13:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20970 (presubmit successful).