WebVR: Use content CVC size for compositor rendering

third_party/WebKit/Source/modules/vr/VRDisplay.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/vr/VRDisplay.h"
 
+#include "core/css/StylePropertySet.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/FrameRequestCallback.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/ScriptedAnimationController.h"
 #include "core/frame/UseCounter.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "gpu/command_buffer/client/gles2_interface.h"
 #include "modules/vr/NavigatorVR.h"
 #include "modules/vr/VRController.h"
 #include "modules/vr/VRDisplayCapabilities.h"
@@ skipping 312 matching lines @@
         "Layer bounds must either be an empty array or have 4 values");
     resolver->reject(exception);
     ReportPresentationResult(PresentationResult::InvalidLayerBounds);
     return promise;
   }
 
   if (!m_capabilities->hasExternalDisplay()) {
     // TODO: Need a proper VR compositor, but for the moment on mobile
     // we'll just make the canvas fullscreen so that VrShell can pick it
     // up through the standard (high latency) compositing path.
-    Fullscreen::requestFullscreen(*m_layer.source(),
-                                  Fullscreen::UnprefixedRequest);
+    auto canvas = m_layer.source();
+    auto inlineStyle = canvas->inlineStyle();
+    if (inlineStyle) {
+      m_fullscreenOrigWidth = inlineStyle->getPropertyValue(CSSPropertyWidth);

[mthiesse, 2016/11/16 21:30:41]

why are we changing CSS properties?

[mthiesse, 2016/11/16 21:31:35]

Just saw your comment in the CL description. Put it here too.

[klausw, 2016/11/16 23:37:39]

Done, with a bit more detail:

      // THREE.js's VREffect sets explicit style.width/height on its rendering
      // canvas based on the non-fullscreen window dimensions, and it keeps
      // those unchanged when presenting. Unfortunately it appears that a
      // fullscreened canvas just gets centered if it has explicitly set a
      // size smaller than the fullscreen dimensions. Manually set size to
      // 100% in this case and restore it when exiting fullscreen. This is a
      // stopgap measure since THREE.js's usage appears legal according to the
      // WebVR API spec. This will no longer be necessary once we can get rid
      // of this fullscreen hack.

+      if (!m_fullscreenOrigWidth.isNull()) {
+        canvas->setInlineStyleProperty(CSSPropertyWidth, "100%");
+      }
+      m_fullscreenOrigHeight = inlineStyle->getPropertyValue(CSSPropertyHeight);
+      if (!m_fullscreenOrigHeight.isNull()) {
+        canvas->setInlineStyleProperty(CSSPropertyHeight, "100%");
+      }
+    } else {
+      m_fullscreenOrigWidth = String();
+      m_fullscreenOrigHeight = String();
+    }
+    Fullscreen::requestFullscreen(*canvas, Fullscreen::UnprefixedRequest);
 
     // Check to see if the canvas is still the current fullscreen
     // element once per second.
     m_fullscreenCheckTimer.startRepeating(1.0, BLINK_FROM_HERE);
   }
 
   if (firstPresent) {
     bool secureContext = scriptState->getExecutionContext()->isSecureContext();
     if (!m_display) {
       forceExitPresent();
@@ skipping 77 matching lines @@
 
   updateLayerBounds();
 
   resolver->resolve();
   m_navigatorVR->fireVRDisplayPresentChange(this);
 }
 
 void VRDisplay::forceExitPresent() {
   if (m_isPresenting) {
     if (!m_capabilities->hasExternalDisplay()) {
-      Fullscreen::fullyExitFullscreen(m_layer.source()->document());
+      auto canvas = m_layer.source();
+      Fullscreen::fullyExitFullscreen(canvas->document());
       m_fullscreenCheckTimer.stop();
+      if (!m_fullscreenOrigWidth.isNull()) {

[bajones, 2016/11/16 21:23:52]

This is all so hacky anyway I don't know how much I care, but we risk resetting
this to an old value if the developer updates it while in VR presentation mode
(which would probably cause their content to break, but at that point it's on
their heads.) Maybe we should just check to see if it's currently set to "100%"
before restoring? Or we can just run with it like this because we intend for the
solution to be short-lived anyway.

[klausw, 2016/11/16 23:37:39]

I don't have strong feelings about this, but at this point I don't think making
the logic more complex has much benefit. Hopefully this code will all go away
soon.

+        canvas->setInlineStyleProperty(CSSPropertyWidth, m_fullscreenOrigWidth);
+        m_fullscreenOrigWidth = String();
+      }
+      if (!m_fullscreenOrigHeight.isNull()) {
+        canvas->setInlineStyleProperty(CSSPropertyWidth,
+                                       m_fullscreenOrigHeight);
+        m_fullscreenOrigHeight = String();
+      }
     } else {
       // Can't get into this presentation mode, so nothing to do here.
     }
     m_navigatorVR->fireVRDisplayPresentChange(this);
   }
 
   m_isPresenting = false;
   m_renderingContext = nullptr;
   m_contextGL = nullptr;
 }
@@ skipping 160 matching lines @@
   visitor->trace(m_capabilities);
   visitor->trace(m_stageParameters);
   visitor->trace(m_eyeParametersLeft);
   visitor->trace(m_eyeParametersRight);
   visitor->trace(m_layer);
   visitor->trace(m_renderingContext);
   visitor->trace(m_scriptedAnimationController);
 }
 
 }  // namespace blink