WebVR: Use content CVC size for compositor rendering

device/vr/android/gvr/gvr_device.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/vr/android/gvr/gvr_device.h"
 
 #include <math.h>
 #include <algorithm>
 
 #include "base/time/time.h"
@@ skipping 37 matching lines @@
   device->rightEye = mojom::VREyeParameters::New();
   mojom::VREyeParametersPtr& left_eye = device->leftEye;
   mojom::VREyeParametersPtr& right_eye = device->rightEye;
 
   left_eye->fieldOfView = mojom::VRFieldOfView::New();
   right_eye->fieldOfView = mojom::VRFieldOfView::New();
 
   left_eye->offset.resize(3);
   right_eye->offset.resize(3);
 
-  // TODO(bajones): GVR has a bug that causes it to return bad render target
-  // sizes when the phone is in portait mode. Send arbitrary,
-  // not-horrifically-wrong values instead.
-  //  gvr::Sizei render_target_size = gvr_api->GetRecommendedRenderTargetSize();
-  left_eye->renderWidth = 1024;   // render_target_size.width / 2;
-  left_eye->renderHeight = 1024;  // render_target_size.height;
-
-  right_eye->renderWidth = left_eye->renderWidth;
-  right_eye->renderHeight = left_eye->renderHeight;
-
   gvr::GvrApi* gvr_api = GetGvrApi();
   if (!gvr_api) {
     // We may not be able to get an instance of GvrApi right away, so
     // stub in some data till we have one.
     device->displayName = "Unknown";
 
     left_eye->fieldOfView->upDegrees = 45;
     left_eye->fieldOfView->downDegrees = 45;
     left_eye->fieldOfView->leftDegrees = 45;
     left_eye->fieldOfView->rightDegrees = 45;
+    left_eye->renderWidth = 1024;

[mthiesse, 2016/11/16 21:30:41]

Maybe move this 1024 value used all over the place to some shared header?

At least keep the comment here about why 1024.

[klausw, 2016/11/16 23:37:39]

I've reverted this part of the change to keep the original
assignment + comment.

I've also added a new kFallbackRenderTargetSize constant to make
this clearer.

+    left_eye->renderHeight = 1024;
 
     right_eye->fieldOfView->upDegrees = 45;
     right_eye->fieldOfView->downDegrees = 45;
     right_eye->fieldOfView->leftDegrees = 45;
     right_eye->fieldOfView->rightDegrees = 45;
+    right_eye->renderWidth = left_eye->renderHeight;
+    right_eye->renderHeight = left_eye->renderHeight;
 
     left_eye->offset[0] = -0.0;
     left_eye->offset[1] = -0.0;
     left_eye->offset[2] = -0.03;
 
     right_eye->offset[0] = 0.0;
     right_eye->offset[1] = 0.0;
     right_eye->offset[2] = 0.03;
 
+    delegate_->SetWebVRRenderSurfaceSize(2 * left_eye->renderWidth,
+                                         left_eye->renderHeight);
+
     return device;
   }
 
+  // In compositor mode, we have to use the current compositor window's
+  // surface size. Would be nice to change it, but that needs more browser
+  // internals to be modified. TODO(klausw): remove this once we can
+  // pick our own surface size.
+  gvr::Sizei compositor_size = delegate_->GetWebVRCompositorSurfaceSize();
+  left_eye->renderWidth = compositor_size.width / 2;
+  left_eye->renderHeight = compositor_size.height;
+  right_eye->renderWidth = left_eye->renderHeight;
+  right_eye->renderHeight = left_eye->renderHeight;
+
   std::string vendor = gvr_api->GetViewerVendor();
   std::string model = gvr_api->GetViewerModel();
   device->displayName = vendor + " " + model;
 
   gvr::BufferViewportList gvr_buffer_viewports =
       gvr_api->CreateEmptyBufferViewportList();
   gvr_buffer_viewports.SetToRecommendedBufferViewports();
 
   gvr::BufferViewport eye_viewport = gvr_api->CreateBufferViewport();
   gvr_buffer_viewports.GetBufferViewport(GVR_LEFT_EYE, &eye_viewport);
@@ skipping 14 matching lines @@
   gvr::Mat4f left_eye_mat = gvr_api->GetEyeFromHeadMatrix(GVR_LEFT_EYE);
   left_eye->offset[0] = -left_eye_mat.m[0][3];
   left_eye->offset[1] = -left_eye_mat.m[1][3];
   left_eye->offset[2] = -left_eye_mat.m[2][3];
 
   gvr::Mat4f right_eye_mat = gvr_api->GetEyeFromHeadMatrix(GVR_RIGHT_EYE);
   right_eye->offset[0] = -right_eye_mat.m[0][3];
   right_eye->offset[1] = -right_eye_mat.m[1][3];
   right_eye->offset[2] = -right_eye_mat.m[2][3];
 
+  delegate_->SetWebVRRenderSurfaceSize(2 * left_eye->renderWidth,
+                                       left_eye->renderHeight);
+
   return device;
 }
 
 mojom::VRPosePtr GvrDevice::GetPose() {
   TRACE_EVENT0("input", "GvrDevice::GetSensorState");
 
   mojom::VRPosePtr pose = mojom::VRPose::New();
 
   pose->timestamp = base::Time::Now().ToJsTime();
 
@@ skipping 110 matching lines @@
 }
 
 gvr::GvrApi* GvrDevice::GetGvrApi() {
   if (!delegate_)
     return nullptr;
 
   return delegate_->gvr_api();
 }
 
 }  // namespace device