Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: runtime/vm/object.h

Issue 25087006: Improve performance of string buffer by modifying concatAll native to allow growable array and an i… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 28056)
+++ runtime/vm/object.h (working copy)
@@ -4774,6 +4774,11 @@
Heap::Space space = Heap::kNew);
static RawString* ConcatAll(const Array& strings,
Heap::Space space = Heap::kNew);
+ // Concat all strings in 'strings' from 'start' to 'end' (excluding).
+ static RawString* ConcatAllRange(const Array& strings,
+ intptr_t start,
+ intptr_t end,
+ Heap::Space space = Heap::kNew);
static RawString* SubString(const String& str,
intptr_t begin_index,
@@ -4894,6 +4899,8 @@
const String& str2,
Heap::Space space);
static RawOneByteString* ConcatAll(const Array& strings,
+ intptr_t start,
+ intptr_t end,
intptr_t len,
Heap::Space space);
@@ -4989,6 +4996,8 @@
const String& str2,
Heap::Space space);
static RawTwoByteString* ConcatAll(const Array& strings,
+ intptr_t start,
+ intptr_t end,
intptr_t len,
Heap::Space space);

Powered by Google App Engine
This is Rietveld 408576698