Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2508673002: Perf: Removing S5s from waterfall (Closed)

Created:
4 years, 1 month ago by benhenry
Modified:
4 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Perf: Removing S5s from waterfall BUG=665142 TEST=NONE Committed: https://crrev.com/c4f575f7106fce8f23a60e0a4f0ed17ddec485bf Cr-Commit-Position: refs/heads/master@{#433276}

Patch Set 1 #

Patch Set 2 : Had to rebase #

Patch Set 3 : Rebasing again #

Patch Set 4 : rebasing again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M testing/buildbot/chromium.perf.json View 1 2 3 1 chunk +0 lines, -31 lines 0 comments Download
M testing/buildbot/chromium.perf.fyi.json View 1 2 3 1 chunk +0 lines, -22 lines 0 comments Download
M tools/perf/generate_perf_json.py View 1 2 3 7 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 38 (24 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508673002/40001
4 years, 1 month ago (2016-11-17 17:40:42 UTC) #16
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-17 17:40:43 UTC) #18
benhenry
PTAL
4 years, 1 month ago (2016-11-17 23:21:58 UTC) #20
eakuefner
enthusiastic tools/perf OWNERS lgtm
4 years, 1 month ago (2016-11-17 23:22:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508673002/60001
4 years, 1 month ago (2016-11-17 23:26:28 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/183251)
4 years, 1 month ago (2016-11-18 01:05:07 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508673002/60001
4 years, 1 month ago (2016-11-18 01:09:51 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/307704)
4 years, 1 month ago (2016-11-18 02:52:32 UTC) #29
benhenry
It looks like Dave is the only person with LGTM perms for chromium.perf.fyi.json. That might ...
4 years, 1 month ago (2016-11-18 17:55:59 UTC) #30
jbudorick
On 2016/11/18 17:55:59, benhenry wrote: > It looks like Dave is the only person with ...
4 years, 1 month ago (2016-11-18 17:57:04 UTC) #31
dtu
lgtm
4 years, 1 month ago (2016-11-18 17:57:51 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508673002/60001
4 years, 1 month ago (2016-11-18 18:03:54 UTC) #34
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-18 20:08:48 UTC) #36
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 20:10:50 UTC) #38
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c4f575f7106fce8f23a60e0a4f0ed17ddec485bf
Cr-Commit-Position: refs/heads/master@{#433276}

Powered by Google App Engine
This is Rietveld 408576698