|
|
Chromium Code Reviews
DescriptionPerf: Removing S5s from waterfall
BUG=665142
TEST=NONE
Committed: https://crrev.com/c4f575f7106fce8f23a60e0a4f0ed17ddec485bf
Cr-Commit-Position: refs/heads/master@{#433276}
Patch Set 1 #Patch Set 2 : Had to rebase #Patch Set 3 : Rebasing again #Patch Set 4 : rebasing again #
Messages
Total messages: 38 (24 generated)
Description was changed from ========== Perf: Removing S5s from waterfall BUG=665142 TEST=NONE ========== to ========== Perf: Removing S5s from waterfall BUG=665142 TEST=NONE ==========
benhenry@google.com changed reviewers: + dtu@chromium.org, eyaich@google.com, jbudorick@chromium.org, martiniss@chromium.org, stip@chromium.org
The CQ bit was checked by dtu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by benhenry@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by benhenry@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL) cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by benhenry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
benhenry@google.com changed reviewers: + eakuefner@chromium.org
PTAL
enthusiastic tools/perf OWNERS lgtm
The CQ bit was checked by benhenry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by benhenry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
It looks like Dave is the only person with LGTM perms for chromium.perf.fyi.json. That might need to be updated, but in the meantime - Dave, PTAL.
On 2016/11/18 17:55:59, benhenry wrote: > It looks like Dave is the only person with LGTM perms for > chromium.perf.fyi.json. That might need to be updated, but in the meantime - > Dave, PTAL. The generic //testing/buildbot/ owners can also approve.
lgtm
The CQ bit was checked by benhenry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Perf: Removing S5s from waterfall BUG=665142 TEST=NONE ========== to ========== Perf: Removing S5s from waterfall BUG=665142 TEST=NONE ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Perf: Removing S5s from waterfall BUG=665142 TEST=NONE ========== to ========== Perf: Removing S5s from waterfall BUG=665142 TEST=NONE Committed: https://crrev.com/c4f575f7106fce8f23a60e0a4f0ed17ddec485bf Cr-Commit-Position: refs/heads/master@{#433276} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/c4f575f7106fce8f23a60e0a4f0ed17ddec485bf Cr-Commit-Position: refs/heads/master@{#433276} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
