[ios] Move NativeAppLauncher upstream

ios/chrome/browser/native_app_launcher/native_app_infobar_delegate_unittest.mm

Index: ios/chrome/browser/native_app_launcher/native_app_infobar_delegate_unittest.mm
diff --git a/ios/chrome/browser/native_app_launcher/native_app_infobar_delegate_unittest.mm b/ios/chrome/browser/native_app_launcher/native_app_infobar_delegate_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..75b6a38f2d15fdea79db05ce5a0b37dd8f78c8a2
--- /dev/null
+++ b/ios/chrome/browser/native_app_launcher/native_app_infobar_delegate_unittest.mm
@@ -0,0 +1,32 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/chrome/browser/native_app_launcher/native_app_infobar_delegate.h"
+
+#include <memory>
+
+#import "ios/public/provider/chrome/browser/native_app_launcher/native_app_types.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/platform_test.h"
+
+namespace {
+
+class NativeAppInfoBarDelegateTest : public PlatformTest {
+ protected:
+  std::unique_ptr<NativeAppInfoBarDelegate> delegate_;
+};
+
+TEST_F(NativeAppInfoBarDelegateTest, TestConstructor) {
+  delegate_.reset(new NativeAppInfoBarDelegate(

[sdefresne, 2016/11/21 08:46:04]

I think you don't need a class with a member variable, but instead you can just
use a local variable:

TEST(NativeAppInfoBarDelegateTest, TestConstructor) {
  std::unique_ptr<NativeAppInfoBarDelegate> delegate;
  delegate = base::MakeUnique<NativeAppInfoBarDelegate>(
      nil, GURL(), NATIVE_APP_INSTALLER_CONTROLLER);
  EXPECT_TRUE(delegate.get());
  ...

However I'm not sure what is the point of that test. It looks like it just
create object and check that "new" returned a non-null pointer. However, "new"
cannot return non-null pointer (if there is no memory available, a hook is
called to release memory, and if it fails, either an exception is raised if the
code is compiled with exception support or a program terminating function,
usually abort, is called), thus the test is pointless.

I'd recommend adding real tests and removing this one (if no other tests can be
written, then just delete the file).

[sczs1, 2016/11/21 17:43:00]

Thanks Sylvain,
I modified the test as you suggested and added some actual check for
identifiers.

+      nil, GURL(), NATIVE_APP_INSTALLER_CONTROLLER));
+  EXPECT_TRUE(delegate_.get());
+  delegate_.reset(new NativeAppInfoBarDelegate(nil, GURL(),
+                                               NATIVE_APP_LAUNCHER_CONTROLLER));
+  EXPECT_TRUE(delegate_.get());
+  delegate_.reset(new NativeAppInfoBarDelegate(
+      nil, GURL(), NATIVE_APP_OPEN_POLICY_CONTROLLER));
+  EXPECT_TRUE(delegate_.get());
+}
+
+}  // namespace