Issue 250863002: kiosk: Fix unable to type in input fields.

Issue 250863002: kiosk: Fix unable to type in input fields. (Closed)

Created:
6 years, 8 months ago by xiyuan

Modified:
6 years, 7 months ago

Reviewers:
Shu Chen, Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

kiosk: Fix unable to type in input fields. BUG=chrome-os-partner:28303 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266299

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/login/app_launch_controller.cc	View		1 chunk	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/250863002/1

6 years, 8 months ago (2014-04-25 08:24:45 UTC) #4

Nikita (slow)

https://codereview.chromium.org/250863002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc File chrome/browser/chromeos/login/app_launch_controller.cc (right): https://codereview.chromium.org/250863002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc#newcode244 chrome/browser/chromeos/login/app_launch_controller.cc:244: profile_->InitChromeOSPreferences(); Should this use similar approach as in https://codereview.chromium.org/253463002 ...

6 years, 7 months ago (2014-04-28 13:04:16 UTC) #6

xiyuan

https://codereview.chromium.org/250863002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc File chrome/browser/chromeos/login/app_launch_controller.cc (right): https://codereview.chromium.org/250863002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc#newcode244 chrome/browser/chromeos/login/app_launch_controller.cc:244: profile_->InitChromeOSPreferences(); On 2014/04/28 13:04:17, Nikita Kostylev wrote: > Should ...

6 years, 7 months ago (2014-04-28 16:38:32 UTC) #7

Nikita (slow)

6 years, 7 months ago (2014-04-28 16:43:09 UTC) #8

Message was sent while issue was closed.

On 2014/04/28 16:38:32, xiyuan wrote:
>
https://codereview.chromium.org/250863002/diff/1/chrome/browser/chromeos/logi...
> File chrome/browser/chromeos/login/app_launch_controller.cc (right):
> 
>
https://codereview.chromium.org/250863002/diff/1/chrome/browser/chromeos/logi...
> chrome/browser/chromeos/login/app_launch_controller.cc:244:
> profile_->InitChromeOSPreferences();
> On 2014/04/28 13:04:17, Nikita Kostylev wrote:
> > Should this use similar approach as in
> https://codereview.chromium.org/253463002
> > instead?
> 
> OAuth2LoginManager code is not executed for kiosk. It is be better just do
> InitChromeOSPreferences.

Makes sense.

Expand Messages | Collapse Messages