Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2508603002: [Findit] Refactoring trigger swarming task pipelines (Closed)

Created:
4 years, 1 month ago by lijeffrey
Modified:
4 years, 1 month ago
Reviewers:
chanli, stgao, chanli1
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Refactoring trigger swarming task pipelines trigger_swarming_task_pipeline.py uses many methods that were supposed to have been refactored out into trigger_base_swarming_task_pipeline to be shared with trigger_flake_swarming_task_pipelines. This change refactors the 3 pipelines to share common code and cleans up the corresponding unit tests. BUG=665644 Committed: https://chromium.googlesource.com/infra/infra/+/8f071f6aa177ac0fedc48a130bb63fa65e43f1b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -428 lines) Patch
M appengine/findit/model/test/wf_swarming_task_test.py View 2 chunks +11 lines, -1 line 0 comments Download
M appengine/findit/model/wf_swarming_task.py View 1 chunk +4 lines, -0 lines 0 comments Download
A + appengine/findit/waterfall/test/trigger_base_swarming_task_result_pipeline_test.py View 4 chunks +12 lines, -12 lines 0 comments Download
M appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py View 2 chunks +39 lines, -129 lines 0 comments Download
M appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py View 1 chunk +36 lines, -133 lines 0 comments Download
M appengine/findit/waterfall/trigger_flake_swarming_task_pipeline.py View 2 chunks +4 lines, -4 lines 0 comments Download
M appengine/findit/waterfall/trigger_swarming_task_pipeline.py View 1 chunk +16 lines, -149 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
lijeffrey
ptal
4 years, 1 month ago (2016-11-15 23:46:39 UTC) #4
chanli1
lgtm
4 years, 1 month ago (2016-11-16 00:54:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508603002/1
4 years, 1 month ago (2016-11-16 03:53:08 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 04:08:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/8f071f6aa177ac0fedc48a130bb63...

Powered by Google App Engine
This is Rietveld 408576698