Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 25086004: offsetWidth on a table cell with fixed width is wrong (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/table/table-cell-offset-width-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBox.cpp
diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp
index aa800cb9f326b74814efcf646a7bf2e121bcd1d8..b0cd4d79b14e72a0f184c0a89d600c638d763fe2 100644
--- a/Source/core/rendering/RenderBox.cpp
+++ b/Source/core/rendering/RenderBox.cpp
@@ -420,7 +420,9 @@ bool RenderBox::requiresLayoutToDetermineWidth() const
|| style->boxSizing() == BORDER_BOX
|| !isRenderBlock()
|| !isRenderBlockFlow()
- || isFlexItemIncludingDeprecated();
+ || isFlexItemIncludingDeprecated()
+ // TableCells can expand beyond a specified width.
+ || isTableCell();
eae 2013/09/27 19:56:56 This should probably be isTableCell() && !table->i
Julien - ping for review 2013/09/27 20:03:54 I don't think so. Fixed table layout will also for
}
LayoutUnit RenderBox::fixedOffsetWidth() const
« no previous file with comments | « LayoutTests/fast/table/table-cell-offset-width-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698