Issue 2508523002: Revert "Remove smoke and observe from SDK DEPS"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2508523002: Revert "Remove smoke and observe from SDK DEPS" (Closed)

Created:
4 years, 1 month ago by kevmoo

Modified:
4 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Remove smoke and observe from SDK DEPS" This reverts commit 4710e92cfc3996307cf08cf9a3a06dc78f9e1f1d. Analyzer tests seem to still want to use the SDK DEPS for observatory – which needs smoke and observe Committed: https://github.com/dart-lang/sdk/commit/90da9eeddcb543d30205571528052c5b239d7bb0

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	.packages	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	DEPS	View		4 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

kevmoo

Committed patchset #1 (id:1) manually as 90da9eeddcb543d30205571528052c5b239d7bb0 (presubmit successful).

4 years, 1 month ago (2016-11-15 20:58:57 UTC) #4

Bill Hesse

4 years, 1 month ago (2016-11-17 15:41:40 UTC) #5

Message was sent while issue was closed.

LGTM.  I thought there was something like that - I knew observatory had its own
tarball of libs, but that there might be a problem.