Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: tests/compiler/dart2js_extra/inference_super_set_call_test.dart

Issue 2508513003: Fix issue #27830: the type of an super-set assignment expression is the type of (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js_extra/inference_super_set_call_test.dart
diff --git a/tests/compiler/dart2js_extra/inference_super_set_call_test.dart b/tests/compiler/dart2js_extra/inference_super_set_call_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..5a5602379271e8a018a8a84973131baa62221d5f
--- /dev/null
+++ b/tests/compiler/dart2js_extra/inference_super_set_call_test.dart
@@ -0,0 +1,46 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Regression test for dart2js: we incorrectly modeled `super.x = rhs` as a
+// call and not an assignment, so the type of the expression was incorrectly
+// assumed to be the return type of the setter rather than the type of the rhs.
+import 'package:expect/expect.dart';
+
+abstract class A {
+ set x(v) {}
+ set z(v) {}
+ set y(v) { return 'hi';}
+}
+
+class S extends A {
+ var _x; // was bad: inferred as null, than [null | int]
+ var _y = ''; // was bad: inferred as String, rather than [String | int]
+ var _z; // was ok : inferred as [null | int]
+
+ set x(v) {
+ _x = super.x = v;
+ }
+
+ set z(v) {
+ super.z = v;
+ _z = v;
+ }
+
+ set y(v) {
+ _y = super.y = v;
+ }
+
+ get isXNull => _x == null;
+ get isZNull => _z == null;
+}
+
+main() {
+ var s = new S()
+ ..x = 2
+ ..y = 2
+ ..z = 2;
+ Expect.equals(false, s.isXNull); // was incorrectly optimized to 'true'
+ Expect.equals(false, s._y is String); // was incorrectly optimized to 'true'
+ Expect.equals(false, s.isZNull); // prints false
+}
« no previous file with comments | « pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698