Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2508513003: Fix issue #27830: the type of an super-set assignment expression is the type of (Closed)

Created:
4 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
4 years, 1 month ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix issue #27830: the type of an super-set assignment expression is the type of the rhs. The issue was introduced in a recent refactor in commit 37afcd5197bb408a4fbfc76bb8fb521ddbb1ca25 BUG= https://github.com/dart-lang/sdk/issues/27830 R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/8103739900de3ed9a6f049ae0b6b1b59f3e6834e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +2 lines, -1 line 0 comments Download
A tests/compiler/dart2js_extra/inference_super_set_call_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Siggi Cherem (dart-lang)
4 years, 1 month ago (2016-11-15 22:46:13 UTC) #4
sra1
lgtm
4 years, 1 month ago (2016-11-15 22:51:15 UTC) #5
Siggi Cherem (dart-lang)
Committed patchset #1 (id:40001) manually as 8103739900de3ed9a6f049ae0b6b1b59f3e6834e (presubmit successful).
4 years, 1 month ago (2016-11-15 23:59:32 UTC) #7
Johnni Winther
4 years, 1 month ago (2016-11-16 08:15:31 UTC) #8
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698