components/history/core/browser/history_backend.h - Issue 2508503002: Fix an issue that temp files are left permanently on storage after chrome crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_backend.h

Issue 2508503002: Fix an issue that temp files are left permanently on storage after chrome crash (Closed)

Patch Set: addressing comments and fix test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_backend.h

diff --git a/components/history/core/browser/history_backend.h b/components/history/core/browser/history_backend.h

index 130d9b7b614085893230f11d58d2106102820da7..39fb916cde16e6a2e844ea3468cac41db5aaa3d6 100644

--- a/components/history/core/browser/history_backend.h

+++ b/components/history/core/browser/history_backend.h

@@ -337,7 +337,7 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,

uint32_t GetNextDownloadId();

void QueryDownloads(std::vector<DownloadRow>* rows);

- void UpdateDownload(const DownloadRow& data);

+ void UpdateDownload(const DownloadRow& data, bool should_commit_immediately);

bool CreateDownload(const DownloadRow& history_info);

void RemoveDownloads(const std::set<uint32_t>& ids);