Fix an issue that temp files are left permanently on storage after chrome crash

chrome/browser/download/download_history_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_history.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <utility>
 #include <vector>
@@ skipping 71 matching lines @@
     if (!slow_create_download_)
       FinishCreateDownload();
   }
 
   void FinishCreateDownload() {
     DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
     create_download_callback_.Run();
     create_download_callback_.Reset();
   }
 
-  void UpdateDownload(const history::DownloadRow& info) override {
+  void UpdateDownload(const history::DownloadRow& info,
+                      bool should_commit_immediately) override {
     DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
     update_download_ = info;

[asanka, 2016/11/16 23:15:57]

Store should_commit_immediately bit and test that it is set as expected when
changing the current path.

[qinmin, 2016/11/17 00:46:30]

Done.

   }
 
   void RemoveDownloads(const IdSet& ids) override {
     DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
     for (IdSet::const_iterator it = ids.begin();
          it != ids.end(); ++it) {
       remove_downloads_.insert(*it);
     }
   }
 
@@ skipping 790 matching lines @@
   FinishCreateDownload();
   EXPECT_TRUE(DownloadHistory::IsPersisted(&item(0)));
 
   // ItemAdded should call OnDownloadUpdated, which should detect that the item
   // changed while it was being added and call UpdateDownload immediately.
   info.opened = true;
   ExpectDownloadUpdated(info);
 }
 
 }  // anonymous namespace