Move scanner tests into the front_end package.

Move scanner tests into the front_end package.

This required moving the following classes into front_end as well:
- CharSequenceReader
- SubSequenceReader
- JenkinsSmiHash

A small amount of the functionality of GatheringErrorListener and
AnalysisError had to be replicated, to avoid a dependency on the
analyzer package.  In a future CL I will either refactor this code to
make it available to the rest of the front end, or, if
GatheringErrorListener and AnalysisError wind up getting moved into
the front end, I will un-do the replication.

I also took the liberty of addition functionality to JenkinsSmiHash to
make it easier to use.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/1c2268b13e67eb8f7b9351aa4ebdec9fd62e70fa

[Paul Berry, 2016-11-15 18:16:22]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2016-11-15 20:51:37]

lgtm

https://codereview.chromium.org/2508483002/diff/1/pkg/front_end/lib/src/base/...
File pkg/front_end/lib/src/base/jenkins_smi_hash.dart (right):

https://codereview.chromium.org/2508483002/diff/1/pkg/front_end/lib/src/base/...
pkg/front_end/lib/src/base/jenkins_smi_hash.dart:6: /// Borrowed from
sdk/lib/math/jenkins_smi_hash.dart.
"Borrowed from sdk/lib/math/jenkins_smi_hash.dart" --> "Originally borrowed from
sdk/lib/math/jenkins_smi_hash.dart. Enhanced with ..."

[Paul Berry, 2016-11-15 22:53:54]

Description was changed from

==========
Move scanner tests into the front_end package.

This required moving the following classes into front_end as well:
- CharSequenceReader
- SubSequenceReader
- JenkinsSmiHash

A small amount of the functionality of GatheringErrorListener and
AnalysisError had to be replicated, to avoid a dependency on the
analyzer package.  In a future CL I will either refactor this code to
make it available to the rest of the front end, or, if
GatheringErrorListener and AnalysisError wind up getting moved into
the front end, I will un-do the replication.

I also took the liberty of addition functionality to JenkinsSmiHash to
make it easier to use.
==========

to

==========
Move scanner tests into the front_end package.

This required moving the following classes into front_end as well:
- CharSequenceReader
- SubSequenceReader
- JenkinsSmiHash

A small amount of the functionality of GatheringErrorListener and
AnalysisError had to be replicated, to avoid a dependency on the
analyzer package.  In a future CL I will either refactor this code to
make it available to the rest of the front end, or, if
GatheringErrorListener and AnalysisError wind up getting moved into
the front end, I will un-do the replication.

I also took the liberty of addition functionality to JenkinsSmiHash to
make it easier to use.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1c2268b13e67eb8f7b9351aa4ebdec9fd62e70fa
==========

[Paul Berry, 2016-11-15 22:53:55]

Committed patchset #1 (id:1) manually as
1c2268b13e67eb8f7b9351aa4ebdec9fd62e70fa (presubmit successful).

[Paul Berry, 2016-11-15 22:54:23]

https://codereview.chromium.org/2508483002/diff/1/pkg/front_end/lib/src/base/...
File pkg/front_end/lib/src/base/jenkins_smi_hash.dart (right):

https://codereview.chromium.org/2508483002/diff/1/pkg/front_end/lib/src/base/...
pkg/front_end/lib/src/base/jenkins_smi_hash.dart:6: /// Borrowed from
sdk/lib/math/jenkins_smi_hash.dart.
On 2016/11/15 20:51:37, Brian Wilkerson wrote:
> "Borrowed from sdk/lib/math/jenkins_smi_hash.dart" --> "Originally borrowed
from
> sdk/lib/math/jenkins_smi_hash.dart. Enhanced with ..."

Done.

[scheglov, 2016-11-16 02:33:54]

LGTM