Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2508443002: [DevTools] Remove dead code from devtools_file_system_indexer.cc (Closed)

Created:
4 years, 1 month ago by Raphael Kubo da Costa (rakuco)
Modified:
4 years, 1 month ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove dead code from devtools_file_system_indexer.cc Index is only instantiated as a leak LazyInstance, so its destructor is never invoked. Index::PrintStats() is never called anywhere. This cleans up the code and avoids -Wunused-function warnings in recent versions of GCC. R=dgozman@chromium.org,pfeldman@chromium.org Committed: https://crrev.com/65005e8e575b752ab1fa84767dbcd49595f26791 Cr-Commit-Position: refs/heads/master@{#432458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -25 lines) Patch
M chrome/browser/devtools/devtools_file_system_indexer.cc View 3 chunks +4 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Raphael Kubo da Costa (rakuco)
4 years, 1 month ago (2016-11-15 16:53:56 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-15 19:31:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508443002/1
4 years, 1 month ago (2016-11-16 09:01:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 11:17:54 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 11:22:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65005e8e575b752ab1fa84767dbcd49595f26791
Cr-Commit-Position: refs/heads/master@{#432458}

Powered by Google App Engine
This is Rietveld 408576698